Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBump serde to 1.0 #17355
Merged
Bump serde to 1.0 #17355
+468
−524
Conversation
highfive
commented
Jun 16, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jun 16, 2017
|
|
Closed
| @@ -479,7 +479,7 @@ const WARNINGS_BUFFER_SIZE: usize = 32; | |||
| /// but does not panic on deserializtion errors. | |||
| fn route_ipc_receiver_to_new_mpsc_receiver_preserving_errors<T>(ipc_receiver: IpcReceiver<T>) | |||
| -> Receiver<Result<T, IpcError>> | |||
| where T: Deserialize + Serialize + Send + 'static | |||
| where T: for<'de> Deserialize<'de> + Serialize + Send + 'static | |||
This comment has been minimized.
This comment has been minimized.
| @@ -2322,7 +2322,7 @@ impl ScriptThread { | |||
| } | |||
|
|
|||
| fn handle_css_error_reporting(&self, pipeline_id: PipelineId, filename: String, | |||
| line: usize, column: usize, msg: String) { | |||
| line: u32, column: u32, msg: String) { | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SimonSapin
Jun 16, 2017
Author
Member
It’s not. servo/rust-cssparser#157 landed in cssparser in the mean time and Servo was not updated for it.
|
@bors-servo r=nox (per IRC discussion) |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 16, 2017
Bump serde to 1.0 This is a rebase of #17325 with `[replace]` entries removed, a bunch more dependencies updated, and some more compile fixes. Original work by @Eijebong, thanks a lot! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17355) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedJun 16, 2017
•
edited by larsbergstrom
This is a rebase of #17325 with
[replace]entries removed, a bunch more dependencies updated, and some more compile fixes. Original work by @Eijebong, thanks a lot!This change is