Implement paint worklet properties #17364

asajeffrey · 2017-06-16T17:17:10Z

This is the final PR to get basic paint worklet support. It adds support for paint worklet properties (https://drafts.css-houdini.org/css-paint-api/#paint-definition-input-properties). When a paint worklet is registered, it specifies a list of CSS properties, and is provided with their computed values when it is invoked.

This is a dependent PR:

"Implemented paint worklets invoking worklet scripts" is #17239.
"Implemented paint worklets rendering contexts" is #17326.

There should be tests added for this, hopefully the existing wpt houdini tests.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #16839
There are tests for these changes

This change is

highfive · 2017-06-16T17:17:15Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/dom/webidls/PaintWorkletGlobalScope.webidl, components/script/dom/webidls/StylePropertyMapReadOnly.webidl, components/script_layout_interface/lib.rs, components/script/dom/testworkletglobalscope.rs, components/script/dom/mod.rs and 23 more
@fitzgen: components/script/dom/webidls/PaintWorkletGlobalScope.webidl, components/script/dom/webidls/StylePropertyMapReadOnly.webidl, components/script_layout_interface/lib.rs, components/script/dom/testworkletglobalscope.rs, components/script/dom/mod.rs and 23 more
@emilio: components/layout/display_list_builder.rs, components/layout/context.rs, components/layout/Cargo.toml, components/layout/lib.rs

highfive · 2017-06-16T17:17:16Z

Warning

These commits modify unsafe code. Please review it carefully!

asajeffrey · 2017-06-16T17:17:39Z

cc @metajack @tschneidereit @jdm.

asajeffrey · 2017-06-16T17:21:42Z

bors-servo · 2017-06-22T16:10:41Z

☔ The latest upstream changes (presumably #17456) made this pull request unmergeable. Please resolve the merge conflicts.

asajeffrey · 2017-06-23T00:29:15Z


        PR servo#17364


        PR servo#17364

bors-servo · 2017-06-30T09:23:22Z

☔ The latest upstream changes (presumably #17239) made this pull request unmergeable. Please resolve the merge conflicts.


        PR servo#17364

asajeffrey · 2017-07-03T19:20:33Z

Rebased. This PRs dependencies have all landed, so it's ready for review.

bors-servo · 2017-07-06T03:36:36Z

☔ The latest upstream changes (presumably #17615) made this pull request unmergeable. Please resolve the merge conflicts.

asajeffrey · 2017-07-11T20:23:31Z

Squashed. @bors-servo: r=jdm

bors-servo · 2017-07-11T20:23:32Z

📌 Commit 7fbd9c5 has been approved by jdm

bors-servo · 2017-07-11T20:40:52Z

⌛ Testing commit 7fbd9c5 with merge 0da75a2...


        Auto merge of #17364 - asajeffrey:script-paint-worklets-properties, r…

…=jdm Implement paint worklet properties  This is the final PR to get basic paint worklet support. It adds support for paint worklet properties (https://drafts.css-houdini.org/css-paint-api/#paint-definition-input-properties). When a paint worklet is registered, it specifies a list of CSS properties, and is provided with their computed values when it is invoked. This is a dependent PR: * "Implemented paint worklets invoking worklet scripts" is #17239. * "Implemented paint worklets rendering contexts" is #17326. There should be tests added for this, hopefully the existing wpt houdini tests. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #16839 - [x] There are tests for these changes    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17364)

bors-servo · 2017-07-11T21:29:16Z

💔 Test failed - mac-rel-wpt4

jdm · 2017-07-11T21:50:44Z

  ▶ Unexpected subtest result in /_mozilla/mozilla/interfaces.html:
  │ FAIL [expected PASS] Interfaces exposed on the window
  │   → assert_true: If this is failing: DANGER, are you sure you want to expose the new interface CSSStyleValue to all webpages as a property on the global? Do not make a change to this file without review from jdm or Ms2ger for that specific change! expected true got false
  │ 
  │ test_interfaces/<@http://web-platform.test:8000/_mozilla/mozilla/interfaces.js:73:7
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  │ test@http://web-platform.test:8000/resources/testharness.js:497:9
  │ test_interfaces@http://web-platform.test:8000/_mozilla/mozilla/interfaces.js:2:3
  └ @http://web-platform.test:8000/_mozilla/mozilla/interfaces.html:13:1


        Implemented paint worklet properties.

asajeffrey · 2017-07-11T22:30:49Z

Made the new interfaces just exposed to Worklet, not Window. @bors-servo r=jdm

bors-servo · 2017-07-11T22:30:49Z

📌 Commit ef033b8 has been approved by jdm

bors-servo · 2017-07-11T22:30:50Z

🌲 The tree is currently closed for pull requests below priority 9000, this pull request will be tested once the tree is reopened

bors-servo · 2017-07-11T23:24:20Z

⌛ Testing commit ef033b8 with merge bc44246...


        Auto merge of #17364 - asajeffrey:script-paint-worklets-properties, r…

…=jdm Implement paint worklet properties  This is the final PR to get basic paint worklet support. It adds support for paint worklet properties (https://drafts.css-houdini.org/css-paint-api/#paint-definition-input-properties). When a paint worklet is registered, it specifies a list of CSS properties, and is provided with their computed values when it is invoked. This is a dependent PR: * "Implemented paint worklets invoking worklet scripts" is #17239. * "Implemented paint worklets rendering contexts" is #17326. There should be tests added for this, hopefully the existing wpt houdini tests. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #16839 - [x] There are tests for these changes    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17364)

bors-servo · 2017-07-12T00:28:25Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing bc44246 to master...


        Auto merge of #17499 - asajeffrey:script-paint-worklets-zoom, r=glennw

Fixed scaling artefacts in paint worklets caused by zoom and hidpi  This PR renders paint worklet canvases at the device pixel resolution, rather than the CSS pixel resolution. It's a dependent PR, building on #17239, #17326 and #17364. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17454 - [X] These changes do not require tests because we don't run reftests with zoom enabled    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17499)


        Auto merge of #17499 - asajeffrey:script-paint-worklets-zoom, r=glennw

Fixed scaling artefacts in paint worklets caused by zoom and hidpi  This PR renders paint worklet canvases at the device pixel resolution, rather than the CSS pixel resolution. It's a dependent PR, building on #17239, #17326 and #17364. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17454 - [X] These changes do not require tests because we don't run reftests with zoom enabled    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17499)


        Auto merge of #17634 - asajeffrey:canvas-image-css-style-value, r=jdm

Implement drawing an image from a CSS style value into a canvas  Implemented drawing a CSS style value into a canvas, which is needed for the Houdini CSS Paint API. This PR is dependent on #17364. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17432. - [X] These changes do not require tests because the existing CSS paint API wpt test cases test this behaviour.    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17634)

asajeffrey added A-content/css A-content/script S-needs-tests labels Jun 16, 2017

highfive assigned mbrubeck Jun 16, 2017

highfive added the S-awaiting-review label Jun 16, 2017

asajeffrey force-pushed the asajeffrey:script-paint-worklets-properties branch from cc7008e to 9a4c11b Jun 20, 2017

highfive added the S-needs-rebase label Jun 22, 2017

asajeffrey force-pushed the asajeffrey:script-paint-worklets-properties branch from 9a784c8 to 486297b Jun 22, 2017

asajeffrey added a commit to asajeffrey/servo that referenced this pull request Jun 23, 2017

PR servo#17364

9a3b41b

asajeffrey mentioned this pull request Jun 23, 2017

Fixed scaling artefacts in paint worklets caused by zoom and hidpi #17499

Merged

4 of 4 tasks complete

asajeffrey added a commit to asajeffrey/servo that referenced this pull request Jun 28, 2017

PR servo#17364

41ba333

highfive added the S-needs-rebase label Jun 30, 2017

asajeffrey added a commit to asajeffrey/servo that referenced this pull request Jun 30, 2017

PR servo#17364

d44ea86

asajeffrey force-pushed the asajeffrey:script-paint-worklets-properties branch from 486297b to 21ab344 Jul 3, 2017

asajeffrey removed the S-needs-rebase label Jul 3, 2017

asajeffrey force-pushed the asajeffrey:script-paint-worklets-properties branch 2 times, most recently from 737a46f to 9db541a Jul 4, 2017

highfive added the S-needs-rebase label Jul 6, 2017

asajeffrey force-pushed the asajeffrey:script-paint-worklets-properties branch from 24349c4 to 0f81cd7 Jul 6, 2017

asajeffrey removed S-needs-rebase S-needs-tests labels Jul 6, 2017

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-squash labels Jul 11, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Jul 11, 2017

Implemented paint worklet properties.

Loading status checks…

ef033b8

asajeffrey force-pushed the asajeffrey:script-paint-worklets-properties branch from 7fbd9c5 to ef033b8 Jul 11, 2017

highfive added S-awaiting-review and removed S-tests-failed labels Jul 11, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Jul 11, 2017

bors-servo merged commit ef033b8 into servo:master Jul 12, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jul 12, 2017

This was referenced Jul 12, 2017

Implement custom element reactions #17614

Merged

Implement MessagePort and MessageChannel #16622

Closed

servo / servo

Implement paint worklet properties #17364

Implement paint worklet properties #17364

asajeffrey commented Jun 16, 2017 •

edited

highfive commented Jun 16, 2017

highfive commented Jun 16, 2017

asajeffrey commented Jun 16, 2017

asajeffrey commented Jun 16, 2017

bors-servo commented Jun 22, 2017

asajeffrey commented Jun 23, 2017

bors-servo commented Jun 30, 2017

asajeffrey commented Jul 3, 2017

bors-servo commented Jul 6, 2017

asajeffrey commented Jul 11, 2017

bors-servo commented Jul 11, 2017

bors-servo commented Jul 11, 2017

bors-servo commented Jul 11, 2017

jdm commented Jul 11, 2017

asajeffrey commented Jul 11, 2017

bors-servo commented Jul 11, 2017

bors-servo commented Jul 11, 2017

bors-servo commented Jul 11, 2017

bors-servo commented Jul 12, 2017

servo / servo

Join GitHub today

Implement paint worklet properties #17364

Implement paint worklet properties #17364

Conversation

asajeffrey commented Jun 16, 2017 • edited

highfive commented Jun 16, 2017

highfive commented Jun 16, 2017

asajeffrey commented Jun 16, 2017

asajeffrey commented Jun 16, 2017

bors-servo commented Jun 22, 2017

asajeffrey commented Jun 23, 2017

bors-servo commented Jun 30, 2017

asajeffrey commented Jul 3, 2017

bors-servo commented Jul 6, 2017

asajeffrey commented Jul 11, 2017

bors-servo commented Jul 11, 2017

bors-servo commented Jul 11, 2017

bors-servo commented Jul 11, 2017

jdm commented Jul 11, 2017

asajeffrey commented Jul 11, 2017

bors-servo commented Jul 11, 2017

bors-servo commented Jul 11, 2017

bors-servo commented Jul 11, 2017

bors-servo commented Jul 12, 2017

asajeffrey commented Jun 16, 2017 •

edited