Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upuse DisplayListBuilder::with_capacity #17406
Merged
+3
−2
Conversation
highfive
commented
Jun 19, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jun 19, 2017
|
|
|
r+ |
|
servo/webrender#1399 landed. |
|
|
|
rebased |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 24, 2017
use DisplayListBuilder::with_capacity DO NOT MERGE until servo/webrender#1399 has landed in Servo. Previously webrender was reserving 1MB of space for each display list (empirically pages weighed between 100k and 10MB when I implemented this). This was problematic for gecko because they used webrender differently. This just brings Servo back to where it was. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17406) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Gankra commentedJun 19, 2017
•
edited by larsbergstrom
DO NOT MERGE until servo/webrender#1399 has landed in Servo.
Previously webrender was reserving 1MB of space for each display list (empirically pages weighed between 100k and 10MB when I implemented this). This was problematic for gecko because they used webrender differently. This just brings Servo back to where it was.
This change is