Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose -moz-context-properties on stylo #17424

Merged
merged 1 commit into from Jun 21, 2017
Merged

Expose -moz-context-properties on stylo #17424

merged 1 commit into from Jun 21, 2017
+0 −1

Conversation

@kuoe0
Copy link
Contributor

kuoe0 commented Jun 20, 2017 •
edited

Gecko already exposed -moz-context-properties behind pref svg.context-properties.content.enabled. I think we should do the same thing on stylo and make the reftests of context-fill and context-stroke pass.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix Bug 1370797
  • There are tests for these changes OR
  • These changes do not require tests because the tests are in gecko.

This change is Reviewable
@kuoe0
Bug 1370797 - Expose -moz-context-properties on stylo
Loading status checks…
436f112 
MozReview-Commit-ID: 2yYuHuKe3Yu
@highfive
Copy link

highfive commented Jun 20, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/inherited_svg.mako.rs
  • @emilio: components/style/properties/longhand/inherited_svg.mako.rs
@highfive
Copy link

highfive commented Jun 20, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@chenpighead
Copy link
Contributor

chenpighead commented Jun 20, 2017

@bors-servo delegate+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2017

✌️ @kuoe0 can now approve this pull request
@kuoe0
Copy link
Contributor Author

kuoe0 commented Jun 20, 2017

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2017

📌 Commit 436f112 has been approved by heycam
@highfive highfive assigned heycam and unassigned asajeffrey Jun 20, 2017
@kuoe0
Copy link
Contributor Author

kuoe0 commented Jun 20, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #17416
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2017

📌 Commit 436f112 has been approved by KuoE0
@kuoe0
Copy link
Contributor Author

kuoe0 commented Jun 20, 2017

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #17416
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2017

📌 Commit 436f112 has been approved by heycam
@bors-servo
Copy link
Contributor

bors-servo commented Jun 21, 2017

⌛ Testing commit 436f112 with merge f62a3e0...
bors-servo added a commit that referenced this pull request Jun 21, 2017
@bors-servo
Auto merge of #17424 - KuoE0:expose-moz-context-properties-on-stylo, …
Loading status checks…
f62a3e0 
…r=heycam

Expose -moz-context-properties on stylo

<!-- Please describe your changes on the following line: -->

Gecko already exposed `-moz-context-properties` behind pref `svg.context-properties.content.enabled`. I think we should do the same thing on stylo and make the reftests of `context-fill` and `context-stroke` pass.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix [Bug 1370797](https://bugzilla.mozilla.org/show_bug.cgi?id=1370797)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because the tests are in gecko.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17424)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 21, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing f62a3e0 to master...
@bors-servo bors-servo merged commit 436f112 into servo:master Jun 21, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@kuoe0 @highfive @chenpighead @bors-servo @asajeffrey @heycam
You can’t perform that action at this time.