Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPaint worklet size should agree with Chrome. #17456
Merged
Conversation
highfive
commented
Jun 21, 2017
|
Heads up! This PR modifies the following files:
|
|
Spec issue: w3c/css-houdini-drafts#417 |
|
r? @emilio |
| @@ -0,0 +1,3 @@ | |||
| [test_paint_worklet_size.html] | |||
| type: reftest | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Travis is complaining because it needs a manifest update, but with that, r=me |
asajeffrey
force-pushed the
asajeffrey:script-paint-worklets-size
branch
from
96edcd0
to
dded87e
|
Sigh, manifest errors. @bors-servo r=emilio |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 22, 2017
Paint worklet size should agree with Chrome. <!-- Please describe your changes on the following line: --> Getting our implementation to agree with Chrome about the definition of the size parameter to a paint worklet. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17376 - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17456) <!-- Reviewable:end -->
|
|
This was referenced Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedJun 21, 2017
•
edited by larsbergstrom
Getting our implementation to agree with Chrome about the definition of the size parameter to a paint worklet.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is