Have CharacterData call children_changed on its parent when data is set. #17501

jyc · 2017-06-23T21:30:32Z

Can't run WPT on my computer, so pushing here to run tests 😢

Have CharacterData.SetData call children_changed on its parent when
data is set (if it is a Text node) so that HTMLStyleElement parents can
re-parse. Add variant ChildrenMutation::Text for it to use as the
mutation.

This fixes an issue where an empty <style> element's data is set but the
style is not updated. An HTMLStyleElement parent re-parses in its
children_changed implementation.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes are part of a series to fix #17182 (github issue number if applicable).

There are tests for these changes OR
These changes do not require tests because _____

This change is

emilio · 2017-06-24T07:13:22Z

@bors-servo try

bors-servo · 2017-06-24T07:13:26Z

⌛ Trying commit 6c3fbac with merge b0e07ef...


        Auto merge of #17501 - jyc:Text-children_changed, r=<try>

Have CharacterData call children_changed on its parent when data is set. **Can't run WPT on my computer, so pushing here to run tests 😢** Have CharacterData.SetData call children_changed on its parent when data is set (if it is a Text node) so that HTMLStyleElement parents can re-parse. Add variant ChildrenMutation::Text for it to use as the mutation. This fixes an issue where an empty <style> element's data is set but the style is not updated. An HTMLStyleElement parent re-parses in its children_changed implementation.  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes are part of a series to fix #17182 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17501)

bors-servo · 2017-06-24T08:20:07Z

💔 Test failed - linux-rel-wpt

jdm · 2017-06-24T12:08:50Z

I suspect we always want to call replace_ node_ranges.

jyc · 2017-06-26T21:01:14Z

Oops, my bad. Shouldn't have pulled that into the branch.

jdm · 2017-06-27T06:41:48Z

@bors-servo: try

bors-servo · 2017-06-27T06:41:52Z

⌛ Trying commit 8d719c7 with merge 0a2345f...


        Auto merge of #17501 - jyc:Text-children_changed, r=<try>

Have CharacterData call children_changed on its parent when data is set. **Can't run WPT on my computer, so pushing here to run tests 😢** Have CharacterData.SetData call children_changed on its parent when data is set (if it is a Text node) so that HTMLStyleElement parents can re-parse. Add variant ChildrenMutation::Text for it to use as the mutation. This fixes an issue where an empty <style> element's data is set but the style is not updated. An HTMLStyleElement parent re-parses in its children_changed implementation.  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes are part of a series to fix #17182 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17501)

bors-servo · 2017-06-27T07:22:47Z

💔 Test failed - mac-rel-css1

jyc · 2017-06-27T17:39:00Z

Test in question, tests/wpt/css-tests/css-variables-1_dev/html/test_variable_legal_values.htm, does:

  var style = document.getElementById("style");
  var styleText = document.createTextNode("");
  style.appendChild(styleText);

  ...

  function assert_allowed_variable_value(value, description) {
    test(function() {
           styleText.data = "#test { \n" +
                            "  --test: red;\n" +
                            "  --test: " + value + ";\n" +
                            "  background-color: red;\n" +
                            "  background-color: var(--test);\n" +
                            "}";

After this commit, we get a lot of {"status": "PASS", "expected": "FAIL", ...} from these guys. Going to update the expectations.

jyc · 2017-06-27T17:42:10Z

@bors-servo: try

EDIT: Finally it works! No one man should have all that power.

bors-servo · 2017-06-27T17:42:14Z

⌛ Trying commit 1059821 with merge 9e2d61c...


        Auto merge of #17501 - jyc:Text-children_changed, r=<try>

Have CharacterData call children_changed on its parent when data is set. **Can't run WPT on my computer, so pushing here to run tests 😢** Have CharacterData.SetData call children_changed on its parent when data is set (if it is a Text node) so that HTMLStyleElement parents can re-parse. Add variant ChildrenMutation::Text for it to use as the mutation. This fixes an issue where an empty <style> element's data is set but the style is not updated. An HTMLStyleElement parent re-parses in its children_changed implementation.  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes are part of a series to fix #17182 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17501)

bors-servo · 2017-06-28T04:18:09Z

💥 Test timed out

jdm · 2017-06-28T07:21:03Z

@bors-servo: retry

bors-servo · 2017-06-28T07:21:07Z

⌛ Trying commit 1059821 with merge 9a0cfe8...


        Auto merge of #17501 - jyc:Text-children_changed, r=<try>

Have CharacterData call children_changed on its parent when data is set. **Can't run WPT on my computer, so pushing here to run tests 😢** Have CharacterData.SetData call children_changed on its parent when data is set (if it is a Text node) so that HTMLStyleElement parents can re-parse. Add variant ChildrenMutation::Text for it to use as the mutation. This fixes an issue where an empty <style> element's data is set but the style is not updated. An HTMLStyleElement parent re-parses in its children_changed implementation.  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes are part of a series to fix #17182 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17501)

bors-servo · 2017-06-28T08:14:42Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True

jyc · 2017-07-12T20:02:27Z

@Manishearth hi! would you have time to review this?

emilio

r=me, with my comments addressed at you wish (none of them are a big deal, just feel free to change it if you agree)

emilio · 2017-07-12T20:29:02Z

components/script/dom/node.rs

+    /// Mutation for when a Text node's data is modified.
+    /// This doesn't change the structure of the list, which is what the other
+    /// variants' fields are stored for at the moment, so this can just have no
+    /// arguments.


nit: this can have no fields instead? Actually, no big deal, it's understandable.

I'd also probably call this TextContentChanged or something like that, but that maybe associates it too much with the textContent property?

"this can have no fields" is more consistent, thanks for catching that! hm, "Text" looks nicer but the other ones are describing actions and "Text" is just a noun. maybe "ChangeText" (the others are present tense infinitives)? then it fits with us calling content_changed and with this applying for Text nodes, maybe

emilio · 2017-07-12T20:29:02Z

components/script/dom/node.rs

    pub fn next_child(&self) -> Option<&Node> {
        match *self {
            ChildrenMutation::Append { .. } => None,
            ChildrenMutation::Insert { next, .. } => Some(next),
            ChildrenMutation::Prepend { next, .. } => Some(next),
            ChildrenMutation::Replace { next, .. } => next,
            ChildrenMutation::ReplaceAll { .. } => None,
+            ChildrenMutation::Text => None,


Hm... Do we restyle properly when the text changed affects how we should match :empty?

Of course probably before this we don't, so it should not block landing, but afterwards probably we still don't do the right thing... In particular, I'd expect servo to fail http://searchfox.org/mozilla-central/source/layout/reftests/bugs/534804-1.html.

If it does, mind filing an issue for it?

I think I will probably file an issue and try to get back to this later, because I really want to get some work in on the project I've been assigned. Will test this quickly, though.

We do fail it! Made issue here: #17695

jdm · 2017-07-13T13:42:28Z

@bors-servo: r=emilio

bors-servo · 2017-07-13T13:42:28Z

📌 Commit 0d36738 has been approved by emilio

bors-servo · 2017-07-13T13:53:31Z

⌛ Testing commit 0d36738 with merge 4a4dc10...


        Auto merge of #17501 - jyc:Text-children_changed, r=emilio

Have CharacterData call children_changed on its parent when data is set. **Can't run WPT on my computer, so pushing here to run tests 😢** Have CharacterData.SetData call children_changed on its parent when data is set (if it is a Text node) so that HTMLStyleElement parents can re-parse. Add variant ChildrenMutation::Text for it to use as the mutation. This fixes an issue where an empty <style> element's data is set but the style is not updated. An HTMLStyleElement parent re-parses in its children_changed implementation.  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes are part of a series to fix #17182 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17501)

bors-servo · 2017-07-13T14:46:28Z

💔 Test failed - linux-rel-css

jdm · 2017-07-13T17:04:22Z


  ▶ Unexpected subtest result in /cssom-1_dev/html/selectorSerialize.htm:
  └ PASS [expected FAIL] single universal selector shows '*' when serialized.

  ▶ Unexpected subtest result in /cssom-1_dev/html/selectorSerialize.htm:
  └ PASS [expected FAIL] single type (simple) selector in the sequence of simple selectors that is not a universal selector

  ▶ Unexpected subtest result in /cssom-1_dev/html/selectorSerialize.htm:
  └ PASS [expected FAIL] single class (simple) selector in the sequence of simple selectors that is not a universal selector

  ▶ Unexpected subtest result in /cssom-1_dev/html/selectorSerialize.htm:
  └ PASS [expected FAIL] single id (simple) selector in the sequence of simple selectors that is not a universal selector

  ▶ Unexpected subtest result in /cssom-1_dev/html/selectorSerialize.htm:
  └ PASS [expected FAIL] single pseudo (simple) selector which does not accept arguments in the sequence of simple selectors that is not a universal selector

  ▶ Unexpected subtest result in /cssom-1_dev/html/selectorSerialize.htm:
  └ PASS [expected FAIL] single pseudo (simple) selector "lang" which accepts arguments in the sequence of simple selectors that is not a universal selector

  ▶ Unexpected subtest result in /cssom-1_dev/html/selectorSerialize.htm:
  └ PASS [expected FAIL] single pseudo (simple) selector ":not" which accepts arguments in the sequence of simple selectors that is not a universal selector

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Simple type selector

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Type selector without a namespace

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Universal selector

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Universal selector without a namespace

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Type selector with namespace

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Universal selector with namespace

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Simple type selector followed by class

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Simple type selector followed by id

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Simple type selector followed by pseudo class

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Simple type selector followed by pseudo element

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Simple type selector followed by atttribute selector

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Type selector without a namespace followed by class

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Type selector without a namespace followed by id

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Type selector without a namespace followed by pseudo class

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Type selector without a namespace followed by pseudo element

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Type selector without a namespace followed by attribute selector

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Universal selector without a namespace followed by class

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Universal selector without a namespace followed by id

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Universal selector without a namespace followed by pseudo class

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Universal selector without a namespace followed by pseudo element

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Universal selector without a namespace followed by attribute selector

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Type selector with namespace followed by class

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Type selector with namespace followed by id

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Type selector with namespace followed by pseudo class

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Type selector with namespace followed by pseudo element

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Type selector with namespace followed by attribute selector

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Universal selector with namespace followed by class

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Universal selector with namespace followed by id

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Universal selector with namespace followed by pseudo class

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Universal selector with namespace followed by pseudo element

  ▶ Unexpected subtest result in /cssom-1_dev/html/serialize-namespaced-type-selectors.htm:
  └ PASS [expected FAIL] Universal selector with namespace followed by attribute selector


        Have CharacterData call children_changed on its parent when data is set.

Have CharacterData.SetData call children_changed on its parent when data is set (if it is a Text node) so that HTMLStyleElement parents can re-parse. Add variant ChildrenMutation::Text for it to use as the mutation. This fixes an issue where an empty <style> element's data is set but the style is not updated. An HTMLStyleElement parent re-parses in its children_changed implementation.

jyc · 2017-07-13T20:02:47Z

@bors-servo: retry

jdm · 2017-07-13T20:48:51Z

@bors-servo: r=emilio

bors-servo · 2017-07-13T20:48:52Z

📌 Commit 4142665 has been approved by emilio

bors-servo · 2017-07-13T21:00:15Z

⌛ Testing commit 4142665 with merge 559c0d1...


        Auto merge of #17501 - jyc:Text-children_changed, r=emilio

Have CharacterData call children_changed on its parent when data is set. **Can't run WPT on my computer, so pushing here to run tests 😢** Have CharacterData.SetData call children_changed on its parent when data is set (if it is a Text node) so that HTMLStyleElement parents can re-parse. Add variant ChildrenMutation::Text for it to use as the mutation. This fixes an issue where an empty <style> element's data is set but the style is not updated. An HTMLStyleElement parent re-parses in its children_changed implementation.  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes are part of a series to fix #17182 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17501)

bors-servo · 2017-07-13T22:05:03Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 559c0d1 to master...


        Auto merge of #17537 - jyc:default-namespace-serialization, r=<try>

Replace Namespace components which map to the default namespace with DefaultNamespace - Fix eliding default namespace when serializing - Fix shortest serialization property when namespace prefix is `*|` and there is no default namespace  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes is part of a series to fix #17182  I'd like to land #17501 first, because it allows some tests for this to work. - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17537)


        Auto merge of #17537 - jyc:default-namespace-serialization, r=<try>

Some fixes to selector serialization re: namespaces and universal selector - Fix eliding default namespace when serializing - Fix shortest serialization property when namespace prefix is `*|` and there is no default namespace - Omit universal selector when serializing to match `cssom/serialize-namespaced-type-selectors` (again so we get the shortest serialization)  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes is part of a series to fix #17182  I'd like to land #17501 first, because it allows some tests for this to work. - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17537)


        Auto merge of #17537 - jyc:default-namespace-serialization, r=<try>

Some fixes to selector serialization re: namespaces and universal selector - Fix eliding default namespace when serializing - Fix shortest serialization property when namespace prefix is `*|` and there is no default namespace - Omit universal selector when serializing to match `cssom/serialize-namespaced-type-selectors` (again so we get the shortest serialization)  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes is part of a series to fix #17182  I'd like to land #17501 first, because it allows some tests for this to work. - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17537)


        Auto merge of #17537 - jyc:default-namespace-serialization, r=<try>

Some fixes to selector serialization re: namespaces and universal selector - Fix eliding default namespace when serializing - Fix shortest serialization property when namespace prefix is `*|` and there is no default namespace - Omit universal selector when serializing to match `cssom/serialize-namespaced-type-selectors` (again so we get the shortest serialization)  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes is part of a series to fix #17182  I'd like to land #17501 first, because it allows some tests for this to work. - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17537)


        Auto merge of #17537 - jyc:default-namespace-serialization, r=<try>

Some fixes to selector serialization re: namespaces and universal selector - Fix eliding default namespace when serializing - Fix shortest serialization property when namespace prefix is `*|` and there is no default namespace - Omit universal selector when serializing to match `cssom/serialize-namespaced-type-selectors` (again so we get the shortest serialization)  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes is part of a series to fix #17182  I'd like to land #17501 first, because it allows some tests for this to work. - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17537)


        Auto merge of #17537 - jyc:default-namespace-serialization, r=emilio

Some fixes to selector serialization re: namespaces and universal selector - Fix eliding default namespace when serializing - Fix shortest serialization property when namespace prefix is `*|` and there is no default namespace - Omit universal selector when serializing to match `cssom/serialize-namespaced-type-selectors` (again so we get the shortest serialization)  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes is part of a series to fix #17182  I'd like to land #17501 first, because it allows some tests for this to work. - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17537)

highfive added the S-tests-failed label Jun 24, 2017

jyc force-pushed the jyc:Text-children_changed branch from 6c3fbac to 8d719c7 Jun 26, 2017

highfive added S-awaiting-review and removed S-tests-failed labels Jun 26, 2017

highfive added the S-tests-failed label Jun 27, 2017

jyc force-pushed the jyc:Text-children_changed branch from 8d719c7 to 1059821 Jun 27, 2017

highfive removed the S-tests-failed label Jun 27, 2017

jyc mentioned this pull request Jul 6, 2017

Implement CSSStyleRule.selectorText. #17538

Merged

3 of 5 tasks complete

jdm assigned Manishearth Jul 12, 2017

emilio approved these changes Jul 12, 2017

View changes

highfive added S-awaiting-merge and removed S-awaiting-review labels Jul 13, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Jul 13, 2017

jyc force-pushed the jyc:Text-children_changed branch from 0d36738 to 4142665 Jul 13, 2017

highfive added S-awaiting-review and removed S-tests-failed labels Jul 13, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Jul 13, 2017

bors-servo merged commit 4142665 into servo:master Jul 13, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jul 13, 2017

servo / servo

Have CharacterData call children_changed on its parent when data is set. #17501

Have CharacterData call children_changed on its parent when data is set. #17501

jyc commented Jun 23, 2017 •

edited by larsbergstrom

emilio commented Jun 24, 2017

bors-servo commented Jun 24, 2017

bors-servo commented Jun 24, 2017

jdm commented Jun 24, 2017

jyc commented Jun 26, 2017

jdm commented Jun 27, 2017

bors-servo commented Jun 27, 2017

bors-servo commented Jun 27, 2017

jyc commented Jun 27, 2017

jyc commented Jun 27, 2017 •

edited

bors-servo commented Jun 27, 2017

bors-servo commented Jun 28, 2017

jdm commented Jun 28, 2017

bors-servo commented Jun 28, 2017

bors-servo commented Jun 28, 2017

jyc commented Jul 12, 2017

emilio left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jdm commented Jul 13, 2017

bors-servo commented Jul 13, 2017

bors-servo commented Jul 13, 2017

bors-servo commented Jul 13, 2017

jdm commented Jul 13, 2017

jyc commented Jul 13, 2017

jdm commented Jul 13, 2017

bors-servo commented Jul 13, 2017

bors-servo commented Jul 13, 2017

bors-servo commented Jul 13, 2017

servo / servo

Join GitHub today

Have CharacterData call children_changed on its parent when data is set. #17501

Have CharacterData call children_changed on its parent when data is set. #17501

Conversation

jyc commented Jun 23, 2017 • edited by larsbergstrom

emilio commented Jun 24, 2017

bors-servo commented Jun 24, 2017

bors-servo commented Jun 24, 2017

jdm commented Jun 24, 2017

jyc commented Jun 26, 2017

jdm commented Jun 27, 2017

bors-servo commented Jun 27, 2017

bors-servo commented Jun 27, 2017

jyc commented Jun 27, 2017

jyc commented Jun 27, 2017 • edited

bors-servo commented Jun 27, 2017

bors-servo commented Jun 28, 2017

jdm commented Jun 28, 2017

bors-servo commented Jun 28, 2017

bors-servo commented Jun 28, 2017

jyc commented Jul 12, 2017

emilio left a comment

This comment has been minimized.

emilio Jul 12, 2017

This comment has been minimized.

emilio Jul 12, 2017

This comment has been minimized.

jyc Jul 12, 2017

This comment has been minimized.

emilio Jul 12, 2017

This comment has been minimized.

emilio Jul 12, 2017

This comment has been minimized.

jyc Jul 12, 2017

This comment has been minimized.

jyc Jul 12, 2017

jdm commented Jul 13, 2017

bors-servo commented Jul 13, 2017

bors-servo commented Jul 13, 2017

bors-servo commented Jul 13, 2017

jdm commented Jul 13, 2017

jyc commented Jul 13, 2017

jdm commented Jul 13, 2017

bors-servo commented Jul 13, 2017

bors-servo commented Jul 13, 2017

bors-servo commented Jul 13, 2017

jyc commented Jun 23, 2017 •

edited by larsbergstrom

jyc commented Jun 27, 2017 •

edited