Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd cli options to write profiler output to InfluxDB #17536
Merged
Conversation
highfive
commented
Jun 27, 2017
|
Heads up! This PR modifies the following files:
|
|
r? @jdm |
|
If it's useful to put the profiler data into a database, then this looks like a fine way to do it. |
components/config/opts.rs
Outdated
| /// (`i.e. -p 5`). | ||
| /// - a file path to write profiling info to a TSV file upon Servo's termination. | ||
| /// (`i.e. -p out.tsv`). | ||
| /// - an InfluxDB hostname to store profiling info upon's Servo's termination. |
This comment has been minimized.
This comment has been minimized.
components/profile/time.rs
Outdated
| let database = match *dbname { | ||
| Some(ref n) => n, | ||
| None => "", | ||
| }; |
This comment has been minimized.
This comment has been minimized.
jdm
Jun 30, 2017
Member
let user = user.as_ref().unwrap_or("");
let password = password.as_ref().unwrap_or("");
let database = dbname.as_ref().unwrap_or("");| let client = create_client(credentials, hosts); | ||
|
|
||
| for (&(ref category, ref meta), ref mut data) in &mut self.buckets { | ||
| data.sort_by(|a, b| { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
components/profile/time.rs
Outdated
| }; | ||
| match client.write_one(measurement, None) { | ||
| Ok(_) => {}, | ||
| Err(_) => warn!("Could not write measurement to profiler db"), |
This comment has been minimized.
This comment has been minimized.
|
r? @jdm |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 6, 2017
Add cli options to write profiler output to InfluxDB - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors This patch adds the command line options and associated code to write the output of running the profiler to an InfluxDB instance, so we can create graphs like [1] with Grafana. This is part of the work required to record and watch PWM results during CI to catch performance regressions. [1] https://screenshots.firefox.com/j6sSZrN7pTuPK2kX/localhost <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17536) <!-- Reviewable:end -->
|
|
This was referenced Jul 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedJun 27, 2017
•
edited
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis patch adds the command line options and associated code to write the output of running the profiler to an InfluxDB instance, so we can create graphs like [1] with Grafana.
This is part of the work required to record and watch PWM results during CI to catch performance regressions.
[1] https://screenshots.firefox.com/j6sSZrN7pTuPK2kX/localhost
This change is