Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLoad fonts only when needed #17545
Closed
Load fonts only when needed #17545
Conversation
highfive
commented
Jun 28, 2017
835f865
to
1257a2f
|
It would be worth seeing if our tests keep working with synchronous loading removed. |
|
@jdm should I run the tests locally or we can run them on the servo test runner ? |
1257a2f
to
0a2f7f0
|
You can certainly run any tests locally, but let's give it a try run: |
bors-servo
added a commit
that referenced
this pull request
Jun 28, 2017
Load fonts only when needed I'm just unsure what to do about the synchronous font loading. It looks like synchronous font loading was just a [temporary patch](https://groups.google.com/d/msg/mozilla.dev.servo/q9QXq4974k0/5xlKe7N1BAAJ). Do you want to keep that features or can I completly remove it ? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #8342 (github issue number if applicable). - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17545) <!-- Reviewable:end -->
|
|
So, we're going to need to make some changes ;) |
|
|
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
charlesvdv commentedJun 28, 2017
•
edited
I'm just unsure what to do about the synchronous font loading. It looks like synchronous font loading was just a temporary patch. Do you want to keep that features or can I completly remove it ?
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is