Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script paint worklets arguments #17546

Merged
merged 1 commit into from Jul 29, 2017
Merged

Script paint worklets arguments #17546

merged 1 commit into from Jul 29, 2017
+78 −27

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Jun 28, 2017 •
edited by larsbergstrom

Implement paint worklet arguments.

This is a dependent PR, only the last commit is in this PR.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #17435
  • These changes do not require tests because there are tests in the most recent wpt.

This change is Reviewable
@highfive
Copy link

highfive commented Jun 28, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/servo/restyle_damage.rs, components/style/values/specified/image.rs, components/style/values/generics/image.rs
  • @KiChjang: components/script/dom/webidls/PaintWorkletGlobalScope.webidl, components/script/dom/webidls/StylePropertyMapReadOnly.webidl, components/script_layout_interface/lib.rs, components/script/dom/testworkletglobalscope.rs, components/script/dom/mod.rs and 23 more
  • @fitzgen: components/script/dom/webidls/PaintWorkletGlobalScope.webidl, components/script/dom/webidls/StylePropertyMapReadOnly.webidl, components/script_layout_interface/lib.rs, components/script/dom/testworkletglobalscope.rs, components/script/dom/mod.rs and 23 more
  • @emilio: components/layout/display_list_builder.rs, components/style/servo/restyle_damage.rs, components/layout/context.rs, components/layout/Cargo.toml, components/layout/lib.rs and 2 more
@highfive
Copy link

highfive commented Jun 28, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2017

☔ The latest upstream changes (presumably #17239) made this pull request unmergeable. Please resolve the merge conflicts.
@asajeffrey asajeffrey force-pushed the asajeffrey:script-paint-worklets-arguments branch from 8094f68 to ed11958 Jun 30, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2017

☔ The latest upstream changes (presumably #17326) made this pull request unmergeable. Please resolve the merge conflicts.
@asajeffrey asajeffrey force-pushed the asajeffrey:script-paint-worklets-arguments branch from ed11958 to 862bdc2 Jul 17, 2017
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 17, 2017

This PR's dependencies merged, so it's ready for review.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2017

☔ The latest upstream changes (presumably #17606) made this pull request unmergeable. Please resolve the merge conflicts.
@asajeffrey asajeffrey force-pushed the asajeffrey:script-paint-worklets-arguments branch from 862bdc2 to e8b6bd6 Jul 17, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2017

☔ The latest upstream changes (presumably #17499) made this pull request unmergeable. Please resolve the merge conflicts.
@asajeffrey asajeffrey force-pushed the asajeffrey:script-paint-worklets-arguments branch from dc678e8 to 335c4c1 Jul 21, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2017

☔ The latest upstream changes (presumably #17634) made this pull request unmergeable. Please resolve the merge conflicts.
@asajeffrey asajeffrey force-pushed the asajeffrey:script-paint-worklets-arguments branch from 335c4c1 to 042c894 Jul 24, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jul 26, 2017

☔ The latest upstream changes (presumably #17868) made this pull request unmergeable. Please resolve the merge conflicts.
@asajeffrey asajeffrey force-pushed the asajeffrey:script-paint-worklets-arguments branch from 752e279 to 2f177b9 Jul 28, 2017
@emilio
emilio approved these changes Jul 28, 2017
View changes
components/layout/display_list_builder.rs
let name = paint_worklet.name.clone();
let arguments = paint_worklet.arguments.iter()
.map(|argument| argument.to_css_string())

This comment has been minimized.

Sign in to view
Copy link
@emilio

emilio Jul 28, 2017

Member

This is kinda unfortunate... but I guess.

This comment has been minimized.

Sign in to view
Copy link
@asajeffrey

asajeffrey Jul 28, 2017

Author Member

Yes, it would be nice to serialize something better than a String, but I'm not sure what that would be :/
@asajeffrey
Implemented paint worklet arguments.
Loading status checks…
d101f9c
@asajeffrey asajeffrey force-pushed the asajeffrey:script-paint-worklets-arguments branch from 2f177b9 to d101f9c Jul 29, 2017
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 29, 2017

Squashed. @bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2017

📌 Commit d101f9c has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2017

⌛ Testing commit d101f9c with merge 097e36b...
bors-servo added a commit that referenced this pull request Jul 29, 2017
@bors-servo
Auto merge of #17546 - asajeffrey:script-paint-worklets-arguments, r=…
Loading status checks…
097e36b 
…emilio

Script paint worklets arguments

<!-- Please describe your changes on the following line: -->

Implement paint worklet arguments.

This is a dependent PR, only the last commit is in this PR.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17435
- [X] These changes do not require tests because there are tests in the most recent wpt.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17546)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 097e36b to master...
@bors-servo bors-servo merged commit d101f9c into servo:master Jul 29, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jul 29, 2017
Merged
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
A-content/css A-content/script
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Paint worklets: implement input arguments
5 participants
@asajeffrey @highfive @bors-servo @emilio @nox
You can’t perform that action at this time.