Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDockerfile WIP for testing #17552
Dockerfile WIP for testing #17552
Conversation
|
Two comments at first glance
|
|
@aneeshusa I'm reluctant to pull the entire salt repo and attempt to apply the relevant states from within the Dockerfile because if we ever use pillar values in the states that the Docker container needs, it'll either need human interaction to add it to the salt master or will just plain break. If working from Salt is essential, we can later switch to publishing a public base image from Servo builds that's created from Salt and then just pull that image in -- but that system is more complex than we need to start out with to get TaskCluster set up. I'll check what happens running mach without installing Rust first. |
|
You can pass a Working from Salt isn't essential, but I think it would be less work in the long term. I'm happy to get something working for Taskcluster :) Here's some old version of the WIP Dockerfile I used to have in servo/saltfs#561:
|
|
I resurrected my old saltfs PR at servo/saltfs#706. |
|
Closing in favor of the saltfs PR. |
edunham commentedJun 28, 2017
•
edited by larsbergstrom
cc @aneeshusa
This represents much less difficulty than I believe the correctly completed solution would entail, so either I'm totally wrong about how hard it is to naively Dockerize the build environment or this is totally wrong. Maybe both.
This change is