Add rudimentary .taskcluster.yml #17580

edunham · 2017-06-30T20:43:48Z

Template mostly from https://tools.taskcluster.net/quickstart/. Steps from the
linux-dev builder in etc/ci/buildbot_steps.yml, but with the real parts
commented out for speed during the testing process.

r? @aneeshusa

I got the first-draft image built and pushed to docker hub at https://hub.docker.com/r/servobrowser/servo-linux-dev which is what this is set to pull from.

cc @gregarndt @imbstack

This change is

aneeshusa

A few style nits; please also fix the test-tidy issues, and make taskcluster-test.sh executable so it can be executed directly.

aneeshusa · 2017-06-30T22:59:00Z

etc/ci/taskcluster-test.sh

@@ -0,0 +1,15 @@
+#! /bin/bash
+
+./mach clean-nightlies --keep 3 --force


I don't think we need this on TC (since the caching is different there).

aneeshusa · 2017-06-30T22:59:00Z

.taskcluster.yml

+        events: []
+    payload:
+      maxRunTime: 3600
+      image: servobrowser/servo-linux-dev


Can this be pinned to a specific image digest?

I'd prefer to not pin this quite yet, as we may need to iterate on the image due to TaskCluster failures and using the latest will save us a lot of spurious commits to the Servo repo. However, we should pin it before we consider gating on TaskCluster results.

So one of the cool things here is if you're trying to get the task just right and iterating on the image and task definition, you could do so using the task creator on our tools site. we can give you permissions to create tasks for the worker type that can be used for servo and you can just iterate there rather than having to edit things in this repo.

aneeshusa · 2017-06-30T22:59:00Z

.taskcluster.yml

+        - >-
+          git clone {{event.head.repo.url}} servo && cd servo && git config
+          advice.detachedHead false && git checkout {{event.head.sha}} &&
+          etc/ci/taskcluster-test.sh


Would be nice if each command was on a separate line, or at the least no command was split across multiple lines.

aneeshusa · 2017-06-30T22:59:00Z

.taskcluster.yml

+          etc/ci/taskcluster-test.sh
+    metadata:
+      name: linux-tests
+      description: run linux tests similarly to BuildBot


nit: capitalize, IMO no need to reference BuildBot, maybe mention linux-dev?

aneeshusa · 2017-06-30T22:59:00Z

etc/ci/taskcluster-test.sh

@@ -0,0 +1,15 @@
+#! /bin/bash
+


I'm not sure if taskcluster already does folding or something like Travis, but it would be nice to add set -x or something so that it's easier to figure out which step fails in the case of an error.

edunham · 2017-07-06T00:04:38Z

Thanks! Those are now fixed.

aneeshusa · 2017-07-06T02:32:37Z

LGTM, although I still think it might be helpful to add set -x for debugging; we can always add it later if necessary. r=me with or without that.

Once this is merged, will TC automatically start running builds?

aneeshusa · 2017-07-07T17:10:07Z

Oh, also don't forget to make the etc/ci/taskcluster-test.sh script executable.

bors-servo · 2017-07-21T23:55:56Z

☔ The latest upstream changes (presumably #17822) made this pull request unmergeable. Please resolve the merge conflicts.

gregarndt · 2017-08-17T21:37:56Z

Just checking in, how's this going? anything we can help out with?

edunham · 2017-12-13T20:52:44Z

@bors-servo r=aneeshusa

bors-servo · 2017-12-13T20:52:45Z

📌 Commit d15607f has been approved by aneeshusa

bors-servo · 2017-12-13T20:52:49Z

⌛ Testing commit d15607f with merge 4f1f4fd...


        Auto merge of #17580 - edunham:taskcluster, r=aneeshusa

@aneeshusa

Add rudimentary .taskcluster.yml Template mostly from https://tools.taskcluster.net/quickstart/. Steps from the linux-dev builder in etc/ci/buildbot_steps.yml, but with the real parts commented out for speed during the testing process. r? @aneeshusa I got the first-draft image built and pushed to docker hub at https://hub.docker.com/r/servobrowser/servo-linux-dev which is what this is set to pull from. cc @gregarndt @imbstack  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17580)

Discussed in person & fixed

bors-servo · 2017-12-13T21:16:28Z

💔 Test failed - linux-dev

aneeshusa · 2017-12-14T17:28:05Z

Our shell script linter is not so smart and requires the set -o {errexit,nounset,pipefail} as the first non-empty/comment lines in scripts. Since we'll be able to debug TC tasks using the TC web console, let's take out the set -x in the .taskcluster.yml for now.

Also, please squash these commits into one so we have good commit messages/history.


        Add .taskcluster.yml

Template mostly from https://tools.taskcluster.net/quickstart/. Steps from the linux-dev builder in etc/ci/buildbot_steps.yml are in taskcluster-test.sh.

edunham · 2017-12-14T19:17:21Z

Moved & squashed up. r? @aneeshusa

aneeshusa · 2017-12-14T19:23:49Z

Thanks for finishing this up! @bors-servo r+

bors-servo · 2017-12-14T19:23:49Z

📌 Commit 5ccca8c has been approved by aneeshusa

bors-servo · 2017-12-14T20:24:00Z

⌛ Testing commit 5ccca8c with merge 7897bd1...


        Auto merge of #17580 - edunham:taskcluster, r=aneeshusa

@aneeshusa

Add rudimentary .taskcluster.yml Template mostly from https://tools.taskcluster.net/quickstart/. Steps from the linux-dev builder in etc/ci/buildbot_steps.yml, but with the real parts commented out for speed during the testing process. r? @aneeshusa I got the first-draft image built and pushed to docker hub at https://hub.docker.com/r/servobrowser/servo-linux-dev which is what this is set to pull from. cc @gregarndt @imbstack  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17580)

bors-servo · 2017-12-14T21:21:23Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: aneeshusa
Pushing 7897bd1 to master...

highfive assigned aneeshusa Jun 30, 2017

highfive added the S-awaiting-review label Jun 30, 2017

edunham force-pushed the edunham:taskcluster branch from 5f1830c to fb9f2ac Jun 30, 2017

aneeshusa reviewed Jun 30, 2017

View changes

aneeshusa added S-needs-code-changes and removed S-awaiting-review labels Jun 30, 2017

edunham force-pushed the edunham:taskcluster branch from fb9f2ac to 961b7ac Jul 6, 2017

highfive added S-awaiting-review and removed S-needs-code-changes labels Jul 6, 2017

aneeshusa removed the S-awaiting-review label Jul 6, 2017

highfive added the S-needs-rebase label Jul 21, 2017

aneeshusa mentioned this pull request Sep 1, 2017

Buildbot jobs fail intermittently with "exceptions.Exception: Actual commit (…) differs from requested commit (…)" #18338

Closed

edunham force-pushed the edunham:taskcluster branch from 961b7ac to d15607f Dec 13, 2017

highfive added the S-awaiting-review label Dec 13, 2017

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Dec 13, 2017

bors-servo mentioned this pull request Dec 13, 2017

mach: Fix cargo-geckolib check / cargo-geckolib build after #19476. #19539

Merged

highfive removed the S-awaiting-merge label Dec 13, 2017

highfive added the S-tests-failed label Dec 13, 2017

aneeshusa added S-needs-code-changes S-needs-squash S-fails-tidy labels Dec 14, 2017

Add .taskcluster.yml

Loading status checks…

5ccca8c

Template mostly from https://tools.taskcluster.net/quickstart/. Steps from the linux-dev builder in etc/ci/buildbot_steps.yml are in taskcluster-test.sh.

edunham force-pushed the edunham:taskcluster branch from d15607f to 5ccca8c Dec 14, 2017

highfive added S-awaiting-review and removed S-tests-failed S-needs-code-changes labels Dec 14, 2017

aneeshusa removed S-fails-tidy S-needs-squash labels Dec 14, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Dec 14, 2017

bors-servo merged commit 5ccca8c into servo:master Dec 14, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Dec 14, 2017

servo / servo

Add rudimentary .taskcluster.yml #17580

Add rudimentary .taskcluster.yml #17580

edunham commented Jun 30, 2017 •

edited by larsbergstrom

aneeshusa left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

edunham commented Jul 6, 2017

aneeshusa commented Jul 6, 2017

aneeshusa commented Jul 7, 2017

bors-servo commented Jul 21, 2017

gregarndt commented Aug 17, 2017

edunham commented Dec 13, 2017

bors-servo commented Dec 13, 2017

bors-servo commented Dec 13, 2017

bors-servo commented Dec 13, 2017

aneeshusa commented Dec 14, 2017

edunham commented Dec 14, 2017

aneeshusa commented Dec 14, 2017

bors-servo commented Dec 14, 2017

bors-servo commented Dec 14, 2017

bors-servo commented Dec 14, 2017

		@@ -0,0 +1,15 @@
		#! /bin/bash

		./mach clean-nightlies --keep 3 --force

servo / servo

Join GitHub today

Add rudimentary .taskcluster.yml #17580

Add rudimentary .taskcluster.yml #17580

Conversation

edunham commented Jun 30, 2017 • edited by larsbergstrom

aneeshusa left a comment

This comment has been minimized.

aneeshusa Jun 30, 2017

This comment has been minimized.

aneeshusa Jun 30, 2017

This comment has been minimized.

edunham Jul 6, 2017

This comment has been minimized.

gregarndt Jul 7, 2017

This comment has been minimized.

aneeshusa Jun 30, 2017

This comment has been minimized.

aneeshusa Jun 30, 2017

This comment has been minimized.

aneeshusa Jun 30, 2017

edunham commented Jul 6, 2017

aneeshusa commented Jul 6, 2017

aneeshusa commented Jul 7, 2017

bors-servo commented Jul 21, 2017

gregarndt commented Aug 17, 2017

edunham commented Dec 13, 2017

bors-servo commented Dec 13, 2017

bors-servo commented Dec 13, 2017

bors-servo commented Dec 13, 2017

aneeshusa commented Dec 14, 2017

edunham commented Dec 14, 2017

aneeshusa commented Dec 14, 2017

bors-servo commented Dec 14, 2017

bors-servo commented Dec 14, 2017

bors-servo commented Dec 14, 2017

edunham commented Jun 30, 2017 •

edited by larsbergstrom