Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWebVR 1.1 spec compatibility #17608
Merged
WebVR 1.1 spec compatibility #17608
Conversation
highfive
commented
Jul 5, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 5, 2017
|
|
|
Is there a link to the specs you mentioned? |
|
The link is not available anymore: https://github.com/w3c/webvr/pulls?q=is%3Aopen+is%3Apr+milestone%3A1.2 The changes were:
|
components/script/dom/vr.rs
Outdated
| @@ -200,7 +200,7 @@ impl VR { | |||
|
|
|||
| fn notify_display_event(&self, display: &VRDisplay, event: &WebVRDisplayEvent) { | |||
| let event = VRDisplayEvent::new_from_webvr(&self.global(), &display, &event); | |||
| event.upcast::<Event>().fire(self.upcast()); | |||
| event.upcast::<Event>().fire(self.global().as_window().upcast::<EventTarget>()); | |||
This comment has been minimized.
This comment has been minimized.
components/script/dom/vrdisplay.rs
Outdated
| @@ -467,7 +484,7 @@ impl VRDisplay { | |||
| fn notify_event(&self, event: &WebVRDisplayEvent) { | |||
| let root = Root::from_ref(&*self); | |||
| let event = VRDisplayEvent::new_from_webvr(&self.global(), &root, &event); | |||
| event.upcast::<Event>().fire(self.upcast()); | |||
| event.upcast::<Event>().fire(self.global().as_window().upcast::<EventTarget>()); | |||
This comment has been minimized.
This comment has been minimized.
| @@ -3,7 +3,7 @@ | |||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| // https://w3c.github.io/webvr/#interface-navigator | |||
| [Pref="dom.webvr.enabled"] | |||
| [NoInterfaceObject] | |||
| interface VR: EventTarget { | |||
This comment has been minimized.
This comment has been minimized.
jdm
Jul 5, 2017
Member
Let's remove the parent interface, as well as from the source implementation.
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 6, 2017
WebVR 1.1 spec compatibility <!-- Please describe your changes on the following line: --> Servo WebVR implementation started when WebVR spec 1.2 was about to be released. 1.2 API included some minor breaking changes from spec 1.1 in order to improve the support of the API in WebWorkers. But eventually the WebVR committee decided not to release 1.2 and make it a major version number with a lot more changes. WebVR API 2.0 is still under heavy churn. This PR removes the WebVR changes that non-released 1.2 version introduced to support full WebVR 1.1 spec. I pushed some GC fixes in a separate commit. See #17076 and servo/rust-mozjs#351 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17608) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MortimerGoro commentedJul 5, 2017
•
edited by larsbergstrom
Servo WebVR implementation started when WebVR spec 1.2 was about to be released. 1.2 API included some minor breaking changes from spec 1.1 in order to improve the support of the API in WebWorkers.
But eventually the WebVR committee decided not to release 1.2 and make it a major version number with a lot more changes. WebVR API 2.0 is still under heavy churn.
This PR removes the WebVR changes that non-released 1.2 version introduced to support full WebVR 1.1 spec.
I pushed some GC fixes in a separate commit. See #17076 and servo/rust-mozjs#351
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is