Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out the generic abstractions around ThreadLocalStyleContext #17615

Merged
merged 1 commit into from Jul 6, 2017
Merged

Rip out the generic abstractions around ThreadLocalStyleContext #17615

merged 1 commit into from Jul 6, 2017

Conversation

@bholley
Copy link
Contributor

bholley commented Jul 5, 2017 •
edited by larsbergstrom

https://bugzilla.mozilla.org/show_bug.cgi?id=1378540

This change is Reviewable
@bholley
Rip out the generic abstractions around ThreadLocalStyleContext.
Loading status checks…
3330653 
MozReview-Commit-ID: 5WTLuk323Ac
@highfive
Copy link

highfive commented Jul 5, 2017

Heads up! This PR modifies the following files:

  • @canaltinova: components/style/parallel.rs, components/style/sequential.rs, components/style/dom.rs, components/style/gecko/traversal.rs, components/style/traversal.rs
  • @emilio: components/layout/traversal.rs, components/style/parallel.rs, components/style/sequential.rs, components/style/dom.rs, components/style/gecko/traversal.rs and 2 more
@highfive
Copy link

highfive commented Jul 5, 2017

warning Warning warning

  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!
@bholley
Copy link
Contributor Author

bholley commented Jul 5, 2017

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2017

📌 Commit 3330653 has been approved by emilio
@highfive highfive assigned emilio and unassigned wafflespeanut Jul 5, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2017

⌛ Testing commit 3330653 with merge 8923a9e...
bors-servo added a commit that referenced this pull request Jul 6, 2017
@bors-servo
Auto merge of #17615 - bholley:simplify_local_context, r=emilio
Loading status checks…
8923a9e 
Rip out the generic abstractions around ThreadLocalStyleContext

https://bugzilla.mozilla.org/show_bug.cgi?id=1378540

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17615)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 8923a9e to master...
@bors-servo bors-servo merged commit 3330653 into servo:master Jul 6, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jul 6, 2017
Merged
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@bholley @highfive @bors-servo @emilio @wafflespeanut
You can’t perform that action at this time.