Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up Stylo error reporter to Firefox devtools #17624

Merged
merged 2 commits into from Jul 6, 2017
Merged

Hook up Stylo error reporter to Firefox devtools #17624

merged 2 commits into from Jul 6, 2017

Conversation

@jdm
Copy link
Member

jdm commented Jul 6, 2017 •
edited by larsbergstrom

Reviewed by @emilio in https://bugzilla.mozilla.org/show_bug.cgi?id=1352669.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable
jdm added 2 commits Jul 6, 2017
@jdm
stylo: Create error reporters linked to documents (bug 1352669)
dc2a500
@jdm
stylo: Update rust-cssparser; extract more specific error types when …
Loading status checks…
f5a3830 
…reporting (bug 1352669).
@highfive
Copy link

highfive commented Jul 6, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/stylesheets/rule_parser.rs, components/style/properties/properties.mako.rs, components/style/Cargo.toml, components/style/gecko/generated/bindings.rs, components/style/stylist.rs and 9 more
  • @canaltinova: components/style/stylesheets/rule_parser.rs, components/style/properties/properties.mako.rs, components/style/Cargo.toml, components/style/gecko/generated/bindings.rs, components/style/stylist.rs and 9 more
  • @KiChjang: components/script/Cargo.toml, components/script_layout_interface/wrapper_traits.rs, components/script_layout_interface/Cargo.toml
  • @fitzgen: components/script/Cargo.toml, components/script_layout_interface/wrapper_traits.rs, components/script_layout_interface/Cargo.toml
  • @emilio: ports/geckolib/glue.rs, components/style/stylesheets/rule_parser.rs, components/style/properties/properties.mako.rs, components/style/Cargo.toml, ports/geckolib/Cargo.toml and 11 more
@highfive
Copy link

highfive commented Jul 6, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@jdm
Copy link
Member Author

jdm commented Jul 6, 2017

@bors-servo: r=emilio p=1
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2017

📌 Commit f5a3830 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2017

⌛ Testing commit f5a3830 with merge 585468d...
bors-servo added a commit that referenced this pull request Jul 6, 2017
@bors-servo
Auto merge of #17624 - jdm:stylo-error-reporter, r=emilio
Loading status checks…
585468d 
Hook up Stylo error reporter to Firefox devtools

Reviewed by @emilio in https://bugzilla.mozilla.org/show_bug.cgi?id=1352669.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17624)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 585468d to master...
@bors-servo bors-servo merged commit f5a3830 into servo:master Jul 6, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
This was referenced Jul 6, 2017
Merged
Merged
@moz-servo-sync moz-servo-sync mentioned this pull request Jul 6, 2017
Merged
moz-servo-sync added a commit to moz-servo-sync/servo that referenced this pull request Jul 6, 2017
Gecko Backout @moz-servo-sync
Backed out changeset fec394734f83 (bug 17624) for build bustage a=bac…
32269fa 
…kout CLOSED TREE

Backs out servo#17624
bors-servo added a commit that referenced this pull request Jul 6, 2017
@bors-servo
Auto merge of #17627 - moz-servo-sync:gecko-backout, r=moz-servo-sync
Loading status checks…
b8d2836 
Backed out changeset fec394734f83 (bug 17624) for build bustage a=backout CLOSED TREE

Backed out changeset fec394734f83 (bug 17624) for build bustage a=backout CLOSED TREE

Backs out #17624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@jdm @highfive @bors-servo @emilio
You can’t perform that action at this time.