Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[DO NOT MERGE] Upgrade to the latest version of WebRender #17649
Conversation
highfive
commented
Jul 10, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 10, 2017
|
@bors-servo try |
[DO NOT MERGE] Upgrade to the latest version of WebRender <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because this shouldn't change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17649) <!-- Reviewable:end -->
|
|
We are already tracking these failures at servo/webrender#1463. Once those are fixed, I'll make this PR ready for review and testing. |
|
The test failures are bugs / missing features that are being exposed by the fix in servo/webrender#1426. Since the fix is correct in this case, I think it's fine to mark those tests as expected failures (since they were accidentally passing previously) and get this WR update reviewed / merged. |
|
|
|
I've updated the test expectations. The one remaining task is to ensure that rust-azure is using the new version of core-text. The PR for that is here: servo/rust-azure#268. |
|
@bors-servo test |
|
@bors-servo try |
|
|
|
|
|
wtf? @bors-servo retry |
[DO NOT MERGE] Upgrade to the latest version of WebRender <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because this shouldn't change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17649) <!-- Reviewable:end -->
|
|
|
Tried one of the tests and got backtrace like this:
|
|
I'm seeing this issue locally too. I think it is rust-lang/rust#43102. Locally I am working around it by reverting the most recent rustup. |
|
|
|
This issue is tracked in #17642. |
|
I was wrong about the failure here. The WebGL failures should be fixed by servo/webrender#1471 when that lands. Afterward, I'll update the WebRender hash and we can try the bots again. |
|
Closing this in favor of #17694 (rebased + latest WR hash). |
mrobinson commentedJul 10, 2017
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is