Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Split style resolution and dynamic change computation. #17688

Merged
merged 11 commits into from Jul 12, 2017
Merged

style: Split style resolution and dynamic change computation. #17688

merged 11 commits into from Jul 12, 2017
+2,265 −3,155

Commits on Jul 12, 2017

  1. style: Derive Default for EagerPseudoStyles. 

    MozReview-Commit-ID: HkTtrV5CcF0
    @emilio
    emilio committed Jul 12, 2017
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    a2f8af9

  2. style: Remove unused AFFECTED_BY_PSEUDO_ELEMENTS StyleRelation. 

    MozReview-Commit-ID: yHldvHm87b
    @emilio
    emilio committed Jul 12, 2017
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    95a2ac5

  3. style: Undo the optimization for grabbing animation rules from the st… 

    …yle data.

This is unfortunate, but for now it complicates things, I would like not needing
a ElementData to get the style of an Element in order to fix all the
getDefaultComputedStyle bugs.

MozReview-Commit-ID: LZvsdFEqrDE
    @emilio
    emilio committed Jul 12, 2017
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    cc94a8b

  4. style: Make RuleTree::root return a reference instead of a strong poi… 

    …nter.

There's no reason it wasn't done before.

MozReview-Commit-ID: G0lMLWmfHbS
    @emilio
    emilio committed Jul 12, 2017
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    fcf85e4

  5. style: Introduce StyleResolverForElement. 

    This still doesn't make use of it so far, but I prefer introducing it
atomically, then introduce its usage.

MozReview-Commit-ID: 9dRUsl3srHp
    @emilio
    emilio committed Jul 12, 2017
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    b4c8ba3

  6. style: Rewrite get*Style using StyleResolverForElement. 

    Removing the ugly.

MozReview-Commit-ID: BvahbMKS7QU
    @emilio
    emilio committed Jul 12, 2017
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    0ad2d39

  7. style: Rewrite restyling to split between resolving styles and handli… 

    …ng changes.

MozReview-Commit-ID: 4BzjbLbFebF
    @emilio
    emilio committed Jul 12, 2017
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    c6d5dbb

  8. style: Allow calling GetBaseComputedStylesForElement for an unstyled … 

    …element.

Before this refactoring, getComputedStyle could have side effects, and left the
style data in the element, so we could never arrive there without data.

There are a few crashtests that caught this, but this was already broken if you
called animate() on an element deep in a display: none subtree.

MozReview-Commit-ID: 1AvOvhAyOP3
    @emilio
    emilio committed Jul 12, 2017
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    d15acc2

  9. style: Remove unnecessary TraversalFlags::FOR_DEFAULT_STYLES. 

    Yay

MozReview-Commit-ID: JiWTEz63AlE
    @emilio
    emilio committed Jul 12, 2017
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    d3c8844

  10. style: Remove StyleRelations. 

    They're unused now. We can add them back if needed.

MozReview-Commit-ID: 92Y2Na0ZbVn
    @emilio
    emilio committed Jul 12, 2017
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    6d6c80e

  11. stylo: Update bindings.

    @emilio
    emilio committed Jul 12, 2017
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    e24d81d
You can’t perform that action at this time.