Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest version of WebRender #17694

Merged
merged 1 commit into from Jul 13, 2017
Merged

Upgrade to the latest version of WebRender #17694

merged 1 commit into from Jul 13, 2017

Conversation

@glennw
Copy link
Member

glennw commented Jul 12, 2017 •
edited by edunham

This change is Reviewable
@mrobinson @gw3583
Upgrade to the latest version of WebRender
Loading status checks…
e58e8ab
@highfive
Copy link

highfive commented Jul 12, 2017

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/tidy/servo_tidy_tests/rust_tidy.rs, python/tidy/servo_tidy/licenseck.py
  • @emilio: components/script/dom/webglbuffer.rs, components/script/dom/webglframebuffer.rs, components/script/dom/webglshader.rs, components/script/dom/webglrenderingcontext.rs, components/layout/query.rs and 14 more
  • @fitzgen: components/script_traits/lib.rs, components/script_traits/lib.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs, components/script/dom/webglbuffer.rs and 23 more
  • @KiChjang: components/script_traits/lib.rs, components/script_traits/lib.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs, components/script/dom/webglbuffer.rs and 34 more
  • @asajeffrey: components/constellation/Cargo.toml, components/constellation/constellation.rs, components/constellation/lib.rs, components/constellation/pipeline.rs
  • @edunham: python/tidy/servo_tidy_tests/rust_tidy.rs, python/tidy/servo_tidy/licenseck.py
@glennw glennw mentioned this pull request Jul 12, 2017
Closed
2 of 5 tasks complete
@glennw
Copy link
Member Author

glennw commented Jul 12, 2017

This is #17649, rebased to latest master and including the updated WR hash that reverts the WebGL failures PR.
@glennw
Copy link
Member Author

glennw commented Jul 12, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2017

⌛ Trying commit e58e8ab with merge 1d55d3c...
bors-servo added a commit that referenced this pull request Jul 12, 2017
@bors-servo
Auto merge of #17694 - glennw:webrender-update, r=<try>
Loading status checks…
1d55d3c 
Upgrade to the latest version of WebRender
@glennw
Copy link
Member Author

glennw commented Jul 12, 2017

Reviewed 85 of 88 files at r1.
Review status: 85 of 88 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@glennw
Copy link
Member Author

glennw commented Jul 12, 2017

Partial review of the easy bits so far. Although I opened the PR, the code changes are all by @mrobinson so I can review the changes.
@glennw
Copy link
Member Author

glennw commented Jul 12, 2017

Reviewed 3 of 88 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True
@glennw
Copy link
Member Author

glennw commented Jul 13, 2017

@bors-servo try- r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2017

📌 Commit e58e8ab has been approved by glennw
@highfive highfive assigned glennw and unassigned mbrubeck Jul 13, 2017
@glennw
Copy link
Member Author

glennw commented Jul 13, 2017

@bors-servo r+ retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #17701
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2017

📌 Commit e58e8ab has been approved by glennw
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2017

⌛ Testing commit e58e8ab with merge 173181a...
bors-servo added a commit that referenced this pull request Jul 13, 2017
@bors-servo
Auto merge of #17694 - glennw:webrender-update, r=glennw
Loading status checks…
173181a 
Upgrade to the latest version of WebRender

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17694)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: glennw
Pushing 173181a to master...
@bors-servo bors-servo mentioned this pull request Jul 13, 2017
Closed
@bors-servo bors-servo merged commit e58e8ab into servo:master Jul 13, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Jul 13, 2017
Merged
Closed
This was referenced Jul 13, 2017
Closed
Merged
Closed
Merged
@glennw glennw deleted the glennw:webrender-update branch Jul 13, 2017
@atouchet atouchet mentioned this pull request Jul 14, 2017
Closed
@mrobinson mrobinson mentioned this pull request Jul 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glennw glennw

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@glennw @highfive @bors-servo @mbrubeck @mrobinson
You can’t perform that action at this time.