Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert "Auto merge of #17701 - bholley:reuse_allocations, r=emilio" #17710
Conversation
highfive
commented
Jul 13, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 13, 2017
|
|
|
r? @heycam |
|
@bors-servo r+ |
|
|
|
@bors-servo p=10 |
bors-servo
added a commit
that referenced
this pull request
Jul 13, 2017
Revert "Auto merge of #17701 - bholley:reuse_allocations, r=emilio" This reverts commit ebfc8f5, reversing changes made to 5585ff2. Animation code can reenter and create a new TLS context from the traversal SequentialTask, so this won't work as written, and it's making test fails. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17710) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedJul 13, 2017
•
edited by larsbergstrom
This reverts commit ebfc8f5, reversing
changes made to 5585ff2.
Animation code can reenter and create a new TLS context from the traversal
SequentialTask, so this won't work as written, and it's making test fails.
This change is