Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse bloom filter and style sharing cache across traversals. #17728

Merged
merged 2 commits into from Jul 14, 2017
Merged

Reuse bloom filter and style sharing cache across traversals. #17728

merged 2 commits into from Jul 14, 2017

Conversation

@emilio
Copy link
Member

emilio commented Jul 14, 2017 •
edited by larsbergstrom

This relands #17701, with a fix for the test failures.

This change is Reviewable
emilio and others added 2 commits Jul 13, 2017
@emilio
style: Ensure sequential tasks run after the bloom filter is dropped.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
af36ce2 
MozReview-Commit-ID: 3LjiPP7THg7
@bors-servo @emilio
Auto merge of #17701 - bholley:reuse_allocations, r=emilio
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
6597178 
reuse the bloom filter and style sharing cache across traversals

https://bugzilla.mozilla.org/show_bug.cgi?id=1380198

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17701)
<!-- Reviewable:end -->
@highfive
Copy link

highfive commented Jul 14, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/lib.rs, components/style/bloom.rs, components/style/sharing/mod.rs, components/style/context.rs
  • @canaltinova: components/style/Cargo.toml, components/style/lib.rs, components/style/bloom.rs, components/style/sharing/mod.rs, components/style/context.rs
  • @fitzgen: components/script/Cargo.toml
  • @KiChjang: components/script/Cargo.toml
@highfive
Copy link

highfive commented Jul 14, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@emilio
Copy link
Member Author

emilio commented Jul 14, 2017

@bors-servo r=bholley,emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2017

📌 Commit 6597178 has been approved by bholley,emilio
@highfive highfive assigned bholley and unassigned metajack Jul 14, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2017

⌛ Testing commit 6597178 with merge f49650c...
bors-servo added a commit that referenced this pull request Jul 14, 2017
@bors-servo
Auto merge of #17728 - emilio:reuse-allocs, r=bholley,emilio
Loading status checks…
f49650c 
Reuse bloom filter and style sharing cache across traversals.

This relands #17701, with a fix for the test failures.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: bholley,emilio
Pushing f49650c to master...
@bors-servo bors-servo merged commit 6597178 into servo:master Jul 14, 2017
3 of 4 checks passed
3 of 4 checks passed
default Build started.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bholley bholley

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @bors-servo @metajack @bholley
You can’t perform that action at this time.