Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim some fat from the traversal #17741

Merged
merged 3 commits into from Jul 15, 2017
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Move clearing of dirty descendants bit closer to the last place it's …

…needed.

In the next patch, we'll move logic to identify the children for traversal into
preprocess_children (which will be renamed), and the set_dirty_descendants logic
will move along with it. So left as-is, the code here will clobber the flags.

MozReview-Commit-ID: 7ZskKWD4QC3
  • Loading branch information
bholley committed Jul 15, 2017
commit e534ec9e47a5c4b1b53085925266529b5989da8d
@@ -666,6 +666,9 @@ where
} else {
element.has_dirty_descendants()
};
if context.shared.traversal_flags.for_animation_only() {

This comment has been minimized.

@emilio

emilio Jul 15, 2017

Member

nit: You could use flags here.

unsafe { element.unset_animation_only_dirty_descendants(); }
}

// Preprocess children, propagating restyle hints and handling sibling
// relationships.
@@ -695,10 +698,6 @@ where
data.clear_restyle_state();
}

if context.shared.traversal_flags.for_animation_only() {
unsafe { element.unset_animation_only_dirty_descendants(); }
}

// There are two cases when we want to clear the dity descendants bit here
// after styling this element.
//
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.