Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upreplace vector iteration by ascii_case_insensitive_phf_map #17754
Conversation
highfive
commented
Jul 17, 2017
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. |
highfive
commented
Jul 17, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 17, 2017
|
|
|
Looks good, thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 17, 2017
replace vector iteration by ascii_case_insensitive_phf_map <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15994 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17754) <!-- Reviewable:end -->
|
|
error[E0308]: mismatched types
--> /Users/servo/buildbot/slave/mac-dev-unit/build/target/geckolib/debug/build/style-8e72fa08530fa207/out/properties.rs:19775:49
|
19775 | if let Some(color) = color_name(ident) {
| ^^^^^ expected &str, found struct `cssparser::CompactCowStr`
|
= note: expected type `&str`
found type `cssparser::CompactCowStr<'_>`
= help: here are some functions which might fulfill your needs:
- .trim()
- .trim_left()
- .trim_right()
error[E0308]: mismatched types
--> /Users/servo/buildbot/slave/mac-dev-unit/build/target/geckolib/debug/build/style-8e72fa08530fa207/out/properties.rs:19776:24
|
19776 | Ok(color)
| ^^^^^ expected enum `gecko_bindings::structs::root::mozilla::LookAndFeel_ColorID`, found reference
|
= note: expected type `gecko_bindings::structs::root::mozilla::LookAndFeel_ColorID`
found type `&gecko_bindings::structs::root::mozilla::LookAndFeel_ColorID`
error: aborting due to 2 previous errors
error: Could not compile `style`.Try |
SergeevPavel
force-pushed the
SergeevPavel:system-colors-refactor
branch
from
82c8dd9
to
f3843ed
SergeevPavel
force-pushed the
SergeevPavel:system-colors-refactor
branch
from
f3843ed
to
6a2f84e
|
@bors-servo r+ |
|
@SergeevPavel: |
|
@bors-servo: r=SimonSapin |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 19, 2017
replace vector iteration by ascii_case_insensitive_phf_map <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15994 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17754) <!-- Reviewable:end -->
|
thank for help |
Thank you! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SergeevPavel commentedJul 17, 2017
•
edited
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is