Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [CEReactions] to webidls #17761

Merged
merged 4 commits into from Jul 18, 2017

Conversation

@cbrewster
Copy link
Member

commented Jul 17, 2017

Relies on #17614


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jul 17, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/webidls/HTMLQuoteElement.webidl, components/script/dom/webidls/HTMLFormElement.webidl, components/script/dom/webidls/HTMLDetailsElement.webidl, components/script/dom/webidls/HTMLImageElement.webidl, components/script/dom/webidls/HTMLMediaElement.webidl and 79 more
  • @KiChjang: components/script/dom/webidls/HTMLQuoteElement.webidl, components/script/dom/webidls/HTMLFormElement.webidl, components/script/dom/webidls/HTMLDetailsElement.webidl, components/script/dom/webidls/HTMLImageElement.webidl, components/script/dom/webidls/HTMLMediaElement.webidl and 79 more
@highfive

This comment has been minimized.

Copy link

commented Jul 17, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@cbrewster cbrewster force-pushed the cbrewster:ce_reactions branch from 8022aca to da322fa Jul 18, 2017

@cbrewster

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2017

r? @jdm

@highfive highfive assigned jdm and unassigned metajack Jul 18, 2017

@cbrewster cbrewster force-pushed the cbrewster:ce_reactions branch from 394c0f0 to 30c08ea Jul 18, 2017

@jdm
jdm approved these changes Jul 18, 2017
@@ -18,7 +18,7 @@ interface Attr {
readonly attribute DOMString name;
[Constant]
readonly attribute DOMString nodeName; // historical alias of .name
[Pure]
[Pure, CEReactions]
attribute DOMString value;
[Pure]

This comment has been minimized.

Copy link
@jdm

jdm Jul 18, 2017

Member

This and nodeValue should have CEReactions too.

@cbrewster cbrewster force-pushed the cbrewster:ce_reactions branch from 30c08ea to 817956d Jul 18, 2017

@cbrewster

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2017

@bors-servo r=jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2017

📌 Commit 817956d has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2017

⌛️ Testing commit 817956d with merge 803e4e1...

bors-servo added a commit that referenced this pull request Jul 18, 2017
Auto merge of #17761 - cbrewster:ce_reactions, r=jdm
Add [CEReactions] to webidls

<!-- Please describe your changes on the following line: -->
Relies on #17614

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17761)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2017

💔 Test failed - linux-rel-wpt

@cbrewster cbrewster force-pushed the cbrewster:ce_reactions branch from 817956d to 9ecb931 Jul 18, 2017

@cbrewster

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2017

@bors-servo r=jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2017

📌 Commit 9ecb931 has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2017

⌛️ Testing commit 9ecb931 with merge a6739cb...

bors-servo added a commit that referenced this pull request Jul 18, 2017
Auto merge of #17761 - cbrewster:ce_reactions, r=jdm
Add [CEReactions] to webidls

<!-- Please describe your changes on the following line: -->
Relies on #17614

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17761)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2017

@bors-servo bors-servo merged commit 9ecb931 into servo:master Jul 18, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.