Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[wip] Resource split #17769
Closed
[wip] Resource split #17769
Conversation
highfive
commented
Jul 18, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 18, 2017
0a78595
to
5fba71c
|
3f721f5
to
a5f7af8
|
|
|
|
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedJul 18, 2017
•
edited by larsbergstrom
don't review yet
Splitting resources in 3 categories:
This is necessary when one wants to embed Servo. We don't want to have to deal with useless files. And eventually, we will want to package these files within the libservo binary (see #15635).
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is