Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: pass old ComputedValues from Element data into Gecko_CalcStyleDifference #17796

Merged
merged 3 commits into from Jul 20, 2017

Conversation

@heycam
Copy link
Member

commented Jul 20, 2017

This is the Servo-side part of https://bugzilla.mozilla.org/show_bug.cgi?id=1380133.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jul 20, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/gecko/generated/bindings.rs, components/style/gecko/restyle_damage.rs, components/style/servo/restyle_damage.rs, components/style/matching.rs
  • @canaltinova: components/style/properties/gecko.mako.rs, components/style/gecko/generated/bindings.rs, components/style/gecko/restyle_damage.rs, components/style/servo/restyle_damage.rs, components/style/matching.rs
  • @emilio: components/style/properties/gecko.mako.rs, components/style/gecko/generated/bindings.rs, components/style/gecko/restyle_damage.rs, components/layout/animation.rs, components/style/servo/restyle_damage.rs and 1 more
@highfive

This comment has been minimized.

Copy link

commented Jul 20, 2017

warning Warning warning

  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!
@heycam

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2017

📌 Commit e12294b has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2017

⌛️ Testing commit e12294b with merge 9cbeee0...

bors-servo added a commit that referenced this pull request Jul 20, 2017
Auto merge of #17796 - heycam:calc-difference, r=emilio
style: pass old ComputedValues from Element data into Gecko_CalcStyleDifference

This is the Servo-side part of https://bugzilla.mozilla.org/show_bug.cgi?id=1380133.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17796)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2017

💔 Test failed - linux-rel-wpt

@emilio

This comment has been minimized.

Copy link
Member

commented Jul 20, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2017

⌛️ Testing commit e12294b with merge 7b71070...

bors-servo added a commit that referenced this pull request Jul 20, 2017
Auto merge of #17796 - heycam:calc-difference, r=emilio
style: pass old ComputedValues from Element data into Gecko_CalcStyleDifference

This is the Servo-side part of https://bugzilla.mozilla.org/show_bug.cgi?id=1380133.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17796)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2017

@bors-servo bors-servo merged commit e12294b into servo:master Jul 20, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
moz-servo-sync added a commit to moz-servo-sync/servo that referenced this pull request Jul 20, 2017
bors-servo added a commit that referenced this pull request Jul 20, 2017
Auto merge of #17800 - moz-servo-sync:gecko-backout, r=moz-servo-sync
Backed out changeset b10e6ba9cbdb because gecko part had to be backed out. r=backout on a CLOSED TREE

Backed out changeset b10e6ba9cbdb because gecko part had to be backed out. r=backout on a CLOSED TREE

Backs out #17796

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17800)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.