Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectors: Don't track class and id ancestor hashes in quirks mode. #17806

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
5 participants
@emilio
Copy link
Member

commented Jul 20, 2017

It's incorrect to track classes and id selectors in a quirks-mode document,
since they should match case-insensitively.

Bug: 1382812
Reviewed-by: bholley
MozReview-Commit-ID: 4uvrfYsWb1v


This change is Reviewable

selectors: Don't track class and id ancestor hashes in quirks mode.
It's incorrect to track classes and id selectors in a quirks-mode document,
since they should match case-insensitively.

Bug: 1382812
Reviewed-by: bholley
MozReview-Commit-ID: 4uvrfYsWb1v
@highfive

This comment has been minimized.

Copy link

commented Jul 20, 2017

Heads up! This PR modifies the following files:

@emilio

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2017

@bors-servo r=bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2017

📌 Commit f879ebc has been approved by bholley

@highfive highfive assigned bholley and unassigned nox Jul 20, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2017

⌛️ Testing commit f879ebc with merge 1e6999b...

bors-servo added a commit that referenced this pull request Jul 21, 2017

Auto merge of #17806 - emilio:quirks-mode-bloom, r=bholley
selectors: Don't track class and id ancestor hashes in quirks mode.

It's incorrect to track classes and id selectors in a quirks-mode document,
since they should match case-insensitively.

Bug: 1382812
Reviewed-by: bholley
MozReview-Commit-ID: 4uvrfYsWb1v

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17806)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2017

@bors-servo bors-servo merged commit f879ebc into servo:master Jul 21, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.