Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upScript paint worklets speculative evaluation #17810
Merged
Conversation
highfive
commented
Jul 20, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 20, 2017
|
|
|
This PR is dependent on #17634. |
asajeffrey
force-pushed the
asajeffrey:script-paint-worklets-speculative-evaluation
branch
from
558002f
to
5976728
|
|
asajeffrey
force-pushed the
asajeffrey:script-paint-worklets-speculative-evaluation
branch
from
5976728
to
372f159
|
|
asajeffrey
force-pushed the
asajeffrey:script-paint-worklets-speculative-evaluation
branch
from
372f159
to
5b61105
|
#17634 landed, so this PR is ready for review! |
|
|
asajeffrey
force-pushed the
asajeffrey:script-paint-worklets-speculative-evaluation
branch
from
31a00a3
to
016af1a
|
|
asajeffrey
force-pushed the
asajeffrey:script-paint-worklets-speculative-evaluation
branch
from
016af1a
to
ffd4c99
|
Looks fine, just a question. |
components/style/traversal.rs
Outdated
| @@ -520,6 +522,8 @@ where | |||
| } | |||
| } | |||
|
|
|||
| notify_paint_worklet(context, data); | |||
This comment has been minimized.
This comment has been minimized.
emilio
Jul 28, 2017
Member
Are you sure you want this outside of the if compute_self block? Do we really always need to paint it even if the style is the same?
This comment has been minimized.
This comment has been minimized.
|
Also, do you have any numbers on this? |
|
|
asajeffrey
force-pushed the
asajeffrey:script-paint-worklets-speculative-evaluation
branch
from
ffd4c99
to
c512f6f
|
@emilio I'm afraid not, to get decent numbers we'd need a page with reasonably complex style/layout and a paint worklet. All the paint worklet demos are quite simple at the moment :/ @bors-servo r=emilio |
|
|
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
S-needs-rebase
S-needs-squash
labels
|
|
|
|
|
|
asajeffrey
force-pushed the
asajeffrey:script-paint-worklets-speculative-evaluation
branch
from
c512f6f
to
936dd3e
|
No actual numbers, but at least the cache is doing its job! @bors-servo r=emilio |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 31, 2017
…valuation, r=emilio Script paint worklets speculative evaluation <!-- Please describe your changes on the following line: --> This PR speculatively calls paint worklets during style, which increases the concurrency, since it increases the chance that the cache will have the right result in it when it comes to layout. The speculation is wasted effort if the size of the element has changed, but this is often not the case. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17486 and #17369. - [X] These changes do not require tests because it's a performance improvement <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17810) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedJul 20, 2017
•
edited by larsbergstrom
This PR speculatively calls paint worklets during style, which increases the concurrency, since it increases the chance that the cache will have the right result in it when it comes to layout. The speculation is wasted effort if the size of the element has changed, but this is often not the case.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is