Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Various ComputedValues fixes #17818

Merged
merged 4 commits into from Jul 21, 2017
Merged

stylo: Various ComputedValues fixes #17818

merged 4 commits into from Jul 21, 2017

Conversation

@Manishearth
Copy link
Member

Manishearth commented Jul 21, 2017 •
edited by larsbergstrom

r=heycam https://bugzilla.mozilla.org/show_bug.cgi?id=1382017

This change is Reviewable
Manishearth added 3 commits Jul 18, 2017
@Manishearth
stylo: Replace stylearc with servo_arc
9776d07
@Manishearth
stylo: Remove usage of ServoComputedValues from binding functions
3c3e439
@Manishearth
stylo: Remove usage of ServoComputedValues from most Gecko code
cca0eac
@highfive
Copy link

highfive commented Jul 21, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs, components/style/gecko/generated/bindings.rs, components/style/gecko/arc_types.rs and 1 more
  • @canaltinova: components/style/properties/gecko.mako.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs, components/style/gecko/generated/bindings.rs, components/style/gecko/arc_types.rs and 1 more
  • @emilio: components/style/properties/gecko.mako.rs, components/style/gecko/generated/structs_debug.rs, ports/geckolib/glue.rs, components/style/gecko/generated/structs_release.rs, components/style/gecko/generated/bindings.rs and 2 more
@highfive
Copy link

highfive commented Jul 21, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member Author

Manishearth commented Jul 21, 2017

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2017

📌 Commit 5f7282a has been approved by heycam
@highfive highfive assigned heycam and unassigned pcwalton Jul 21, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2017

⌛ Testing commit 5f7282a with merge 3baacdf...
bors-servo added a commit that referenced this pull request Jul 21, 2017
@bors-servo
Auto merge of #17818 - Manishearth:stylo-fixup, r=heycam
Loading status checks…
3baacdf 
stylo: Various ComputedValues fixes

r=heycam https://bugzilla.mozilla.org/show_bug.cgi?id=1382017
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2017

💔 Test failed - linux-dev
@Manishearth Manishearth force-pushed the Manishearth:stylo-fixup branch from 5f7282a to 1d2495c Jul 21, 2017
@Manishearth
Copy link
Member Author

Manishearth commented Jul 21, 2017

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2017

📌 Commit 1d2495c has been approved by heycam
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2017

⌛ Testing commit 1d2495c with merge 2e1eed1...
bors-servo added a commit that referenced this pull request Jul 21, 2017
@bors-servo
Auto merge of #17818 - Manishearth:stylo-fixup, r=heycam
Loading status checks…
2e1eed1 
stylo: Various ComputedValues fixes

r=heycam https://bugzilla.mozilla.org/show_bug.cgi?id=1382017

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17818)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2017

💔 Test failed - linux-dev
@Manishearth
stylo: Rename ServoComputedValues -> ServoComputedData
Loading status checks…
b332a06 
ServoComputedValues is confusing because ComputedValues is actually
ServoStyleContext on the C++ side.
@Manishearth Manishearth force-pushed the Manishearth:stylo-fixup branch from 1d2495c to b332a06 Jul 21, 2017
@Manishearth
Copy link
Member Author

Manishearth commented Jul 21, 2017

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2017

📌 Commit b332a06 has been approved by heycam
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2017

⌛ Testing commit b332a06 with merge 992c647...
bors-servo added a commit that referenced this pull request Jul 21, 2017
@bors-servo
Auto merge of #17818 - Manishearth:stylo-fixup, r=heycam
Loading status checks…
992c647 
stylo: Various ComputedValues fixes

r=heycam https://bugzilla.mozilla.org/show_bug.cgi?id=1382017

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17818)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing 992c647 to master...
@bors-servo bors-servo merged commit b332a06 into servo:master Jul 21, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:stylo-fixup branch Jul 21, 2017
@Manishearth Manishearth mentioned this pull request Jul 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Manishearth @highfive @bors-servo @pcwalton @heycam
You can’t perform that action at this time.