Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement restrictions on which properties apply to which pseudo-elements #17821

Merged
merged 3 commits into from Jul 21, 2017

Conversation

Projects
None yet
5 participants
@bzbarsky
Copy link
Contributor

commented Jul 21, 2017

::first-line, ::first-letter, and ::placeholder don't allow all properties to apply to them.


  • There are tests for these changes OR
  • These changes do not require tests because they're Gecko-only for the moment, and Gecko has tests.

This change is Reviewable

bzbarsky added some commits Jul 21, 2017

Add property flags for which properties apply to certain pseudo-eleme…
…nts. r=emilio

These flags can be used to flag properties that apply to ::first-letter, ::first-line, and ::placeholder

Part 1 of the fix for Gecko bug 1382786 <https://bugzilla.mozilla.org/show_bug.cgi?id=1382786>.
Filter out non-applying properties when cascading style for ::first-l…
…etter/::first-line/::placeholder. r=emilio

Part 3 of the fix for Gecko bug 1382786 <https://bugzilla.mozilla.org/show_bug.cgi?id=1382786>.
@highfive

This comment has been minimized.

Copy link

commented Jul 21, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/inherited_text.mako.rs, components/style/properties/longhand/effects.mako.rs, components/style/properties/longhand/margin.mako.rs, components/style/properties/longhand/background.mako.rs, components/style/gecko/pseudo_element.rs and 9 more
  • @canaltinova: components/style/properties/longhand/inherited_text.mako.rs, components/style/properties/longhand/effects.mako.rs, components/style/properties/longhand/margin.mako.rs, components/style/properties/longhand/background.mako.rs, components/style/gecko/pseudo_element.rs and 9 more
  • @emilio: components/style/properties/longhand/inherited_text.mako.rs, components/style/properties/longhand/effects.mako.rs, components/style/properties/longhand/margin.mako.rs, components/style/properties/longhand/background.mako.rs, components/style/gecko/pseudo_element.rs and 9 more
@highfive

This comment has been minimized.

Copy link

commented Jul 21, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@bzbarsky

This comment has been minimized.

Copy link
Contributor Author

commented Jul 21, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2017

📌 Commit 86b3b6a has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2017

⌛️ Testing commit 86b3b6a with merge 4bf8e44...

bors-servo added a commit that referenced this pull request Jul 21, 2017

Auto merge of #17821 - bzbarsky:pseudo-prop-restrictions, r=emilio
Implement restrictions on which properties apply to which pseudo-elements

::first-line, ::first-letter, and ::placeholder don't allow all properties to apply to them.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1382786

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they're Gecko-only for the moment, and Gecko has tests.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17821)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2017

@bors-servo bors-servo merged commit 86b3b6a into servo:master Jul 21, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.