Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: Make -Z show-parallel-layout show something useful again. #17824

Merged
merged 1 commit into from Jul 23, 2017

Conversation

@emilio
Copy link
Member

commented Jul 22, 2017

I broke this when we switched to rayon, but now rayon added support for getting the worker index there's no reason for not bringing it back to life.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jul 22, 2017

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@emilio

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2017

r? @stshine

@bors-servo delegate=stshine

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2017

✌️ @stshine can now approve this pull request

@highfive highfive assigned stshine and unassigned KiChjang Jul 22, 2017

@emilio

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2017

⌛️ Trying commit 1c5d522 with merge dae9a59...

bors-servo added a commit that referenced this pull request Jul 22, 2017
Auto merge of #17824 - emilio:debug-par-layout, r=<try>
layout: Make -Z show-parallel-layout show something useful again.

I broke this when we switched to rayon, but now rayon added support for getting the worker index there's no reason for not bringing it back to life.
@emilio

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2017

@stshine

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2017

Nice!

@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2017

📌 Commit 1c5d522 has been approved by stshine

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2017

⌛️ Testing commit 1c5d522 with merge d0561e7...

bors-servo added a commit that referenced this pull request Jul 23, 2017
Auto merge of #17824 - emilio:debug-par-layout, r=stshine
layout: Make -Z show-parallel-layout show something useful again.

I broke this when we switched to rayon, but now rayon added support for getting the worker index there's no reason for not bringing it back to life.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17824)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2017

@bors-servo bors-servo merged commit 1c5d522 into servo:master Jul 23, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@emilio emilio deleted the emilio:debug-par-layout branch Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.