Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Move the RELEVANT_LINK_VISITED flag to servo. #17825

Merged
merged 1 commit into from Jul 23, 2017

Conversation

Projects
None yet
4 participants
@emilio
Copy link
Member

commented Jul 23, 2017

Bug: 1383307
Reviewed-by: Manishearth


This change is Reviewable

style: Move the RELEVANT_LINK_VISITED flag to servo.
And kill one GetParentAllowServo call while at it, and some other dumbness...

Bug: 1383307
Reviewed-by: Manishearth
@highfive

This comment has been minimized.

Copy link

commented Jul 23, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/style_resolver.rs, components/style/style_adjuster.rs, components/style/dom.rs, components/style/gecko/wrapper.rs, components/style/properties/properties.mako.rs and 1 more
  • @canaltinova: components/style/style_resolver.rs, components/style/style_adjuster.rs, components/style/dom.rs, components/style/gecko/wrapper.rs, components/style/properties/properties.mako.rs and 1 more
@highfive

This comment has been minimized.

Copy link

commented Jul 23, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2017

Do not land yet, I'll coordiland tomorrow.

@emilio

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2017

@bors-servo r=manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2017

📌 Commit 4e0492c has been approved by manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2017

⌛️ Testing commit 4e0492c with merge 14b12ee...

bors-servo added a commit that referenced this pull request Jul 23, 2017

Auto merge of #17825 - emilio:is-visited, r=manishearth
style: Move the RELEVANT_LINK_VISITED flag to servo.

Bug: 1383307
Reviewed-by: Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17825)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2017

@bors-servo bors-servo merged commit 4e0492c into servo:master Jul 23, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.