Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update step annotations in script's prepare method #17827

Merged
merged 1 commit into from Jul 23, 2017

Conversation

@cynicaldevil
Copy link
Contributor

commented Jul 23, 2017

The step annotations in the code were outdated, and did not match the spec: https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jul 23, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/htmlscriptelement.rs
  • @KiChjang: components/script/dom/htmlscriptelement.rs
@highfive

This comment has been minimized.

Copy link

commented Jul 23, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm

This comment has been minimized.

Copy link
Member

commented Jul 23, 2017

@bors-servo: r+
Thanks!

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2017

📌 Commit 15ac245 has been approved by jdm

@highfive highfive assigned jdm and unassigned mbrubeck Jul 23, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2017

⌛️ Testing commit 15ac245 with merge 548d65d...

bors-servo added a commit that referenced this pull request Jul 23, 2017
Auto merge of #17827 - cynicaldevil:fix-step-annotations, r=jdm
Update step annotations in script's prepare method

<!-- Please describe your changes on the following line: -->
The step annotations in the code were outdated, and did not match the spec: https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17827)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2017

@bors-servo bors-servo merged commit 15ac245 into servo:master Jul 23, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@cynicaldevil cynicaldevil deleted the cynicaldevil:fix-step-annotations branch Jul 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.