Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "resize" DOM Event. #1783

Merged
merged 1 commit into from Feb 28, 2014
Merged

Implement "resize" DOM Event. #1783

merged 1 commit into from Feb 28, 2014

Conversation

@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Feb 28, 2014

#1715
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Feb 28, 2014

Critic review: https://critic.hoppipolla.co.uk/r/907

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Feb 28, 2014

@jdm how do we test this?
@jdm
Copy link
Member

jdm commented Feb 28, 2014

No automated tests are possible right now. You can create a manual test by adding an event listener for resize and resizing the window.
@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Feb 28, 2014

@jdm r?
@tetsuharuohzeki
Implement "resize" DOM Event.
Loading status checks…
b3536d1 
* We cannot automate this feature.
* So this testcase is a manual test.
@jdm

This comment has been minimized.

Sign in to view
Copy link

jdm commented on b3536d1 Feb 28, 2014

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on b3536d1 Feb 28, 2014

saw approval from jdm
at tetsuharuohzeki@b3536d1

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 28, 2014

merging saneyuki/servo/resize = b3536d1 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 28, 2014

saneyuki/servo/resize = b3536d1 merged ok, testing candidate = def5483

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 28, 2014

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/995
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/950

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 28, 2014

fast-forwarding master to auto = def5483
bors-servo pushed a commit that referenced this pull request Feb 28, 2014
bors-servo
auto merge of #1783 : saneyuki/servo/resize, r=jdm
def5483 
#1715
@bors-servo bors-servo closed this Feb 28, 2014
@bors-servo bors-servo merged commit b3536d1 into servo:master Feb 28, 2014
1 check passed
1 check passed
default all tests passed
@tetsuharuohzeki tetsuharuohzeki deleted the tetsuharuohzeki:resize branch Feb 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@tetsuharuohzeki @hoppipolla-critic-bot @jdm @bors-servo
You can’t perform that action at this time.