Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Correctly calculate inline sizes for table rows with border collapse #17836

Closed
wants to merge 1 commit into from
Closed

(WIP) Correctly calculate inline sizes for table rows with border collapse #17836

wants to merge 1 commit into from

Conversation

@KiChjang
Copy link
Member

KiChjang commented Jul 24, 2017 •
edited by larsbergstrom

Fixes #16736.

This change is Reviewable
@KiChjang
WIP
Loading status checks…
6e52f99
@highfive
Copy link

highfive commented Jul 24, 2017

Heads up! This PR modifies the following files:

  • @emilio: components/layout/fragment.rs
@highfive
Copy link

highfive commented Jul 24, 2017

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@KiChjang
Copy link
Member Author

KiChjang commented Jul 24, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2017

⌛ Trying commit 6e52f99 with merge 9834251...
bors-servo added a commit that referenced this pull request Jul 24, 2017
@bors-servo
Auto merge of #17836 - KiChjang:fix-border-collapse-table, r=<try>
Loading status checks…
9834251 
(WIP) Correctly calculate inline sizes for table rows with border collapse

Fixes #16736.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2017

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Jul 24, 2017 

  ▶ FAIL [expected PASS] /_mozilla/css/border_collapse_simple_a.html
  └   → /_mozilla/css/border_collapse_simple_a.html e144e56ffda8a0c0a7f1c06510b62f8ec43cce4c
/_mozilla/css/border_collapse_simple_ref.html c41cdce36bc0b9c88fb61afdd631e17e8ec148d9
Testing e144e56ffda8a0c0a7f1c06510b62f8ec43cce4c == c41cdce36bc0b9c88fb61afdd631e17e8ec148d9
@KiChjang
Copy link
Member Author

KiChjang commented Jul 30, 2017 •
edited

Ack, I suspect that we need to special case specified border widths when calculating border collapse...
@KiChjang
Copy link
Member Author

KiChjang commented Aug 26, 2017

I can't commit to working on this anymore.
@KiChjang KiChjang closed this Aug 26, 2017
@KiChjang KiChjang deleted the KiChjang:fix-border-collapse-table branch Aug 26, 2017
@KiChjang KiChjang mentioned this pull request Aug 26, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-awaiting-review S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@KiChjang @highfive @bors-servo @jdm @Manishearth
You can’t perform that action at this time.