Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Read mName as a raw nsIAtom* from NodeInfoInner. #17844

Merged
merged 2 commits into from Jul 24, 2017

Conversation

Projects
None yet
6 participants
@emilio
Copy link
Member

commented Jul 24, 2017

Changes for bug 1383756.


This change is Reviewable

ehsan and others added some commits Jul 24, 2017

@highfive

This comment has been minimized.

Copy link

commented Jul 24, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/wrapper.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko_string_cache/mod.rs, components/style/gecko/generated/structs_release.rs
  • @canaltinova: components/style/gecko/wrapper.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko_string_cache/mod.rs, components/style/gecko/generated/structs_release.rs
@highfive

This comment has been minimized.

Copy link

commented Jul 24, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2017

@bors-servo r=bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2017

📌 Commit 0e80710 has been approved by bholley

@highfive highfive assigned bholley and unassigned glennw Jul 24, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2017

⌛️ Testing commit 0e80710 with merge 897f5d8...

bors-servo added a commit that referenced this pull request Jul 24, 2017

Auto merge of #17844 - emilio:is-visited, r=bholley
stylo: Read mName as a raw nsIAtom* from NodeInfoInner.

Changes for bug 1383756.
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2017

@bors-servo bors-servo merged commit 0e80710 into servo:master Jul 24, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@emilio emilio referenced this pull request Jul 24, 2017

Merged

Servo changes for bug 1383756 #17842

0 of 5 tasks complete

@emilio emilio deleted the emilio:is-visited branch Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.