Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: serialize radial gradients using modern unprefixed style #17868

Merged
merged 1 commit into from Jul 26, 2017

Conversation

@ferjm
Copy link
Member

ferjm commented Jul 26, 2017

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

https://bugzilla.mozilla.org/show_bug.cgi?id=1380259


This change is Reviewable

@highfive
Copy link

highfive commented Jul 26, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/specified/image.rs, components/style/values/generics/image.rs, components/style/gecko/conversions.rs
  • @canaltinova: components/style/values/specified/image.rs, components/style/values/generics/image.rs, components/style/gecko/conversions.rs
  • @emilio: components/style/values/specified/image.rs, components/style/values/generics/image.rs, components/style/gecko/conversions.rs
@highfive
Copy link

highfive commented Jul 26, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@ferjm ferjm requested review from nox and removed request for nox Jul 26, 2017
@ferjm
Copy link
Member Author

ferjm commented Jul 26, 2017

@bors-servo r=xidorn

@bors-servo
Copy link
Contributor

bors-servo commented Jul 26, 2017

📌 Commit c50e892 has been approved by xidorn

@bors-servo
Copy link
Contributor

bors-servo commented Jul 26, 2017

Testing commit c50e892 with merge ef23338...

bors-servo added a commit that referenced this pull request Jul 26, 2017
stylo: serialize radial gradients using modern unprefixed style

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

https://bugzilla.mozilla.org/show_bug.cgi?id=1380259

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17868)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 26, 2017

@bors-servo bors-servo merged commit c50e892 into servo:master Jul 26, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jul 26, 2017
4 of 4 tasks complete
emilio added a commit to emilio/servo that referenced this pull request Jul 26, 2017
…, r=xidorn"

This reverts commit ef23338, reversing
changes made to f61528d.

This broke a bunch of tests in m-c, like:

  https://treeherder.mozilla.org/logviewer.html#?job_id=118007409&repo=autoland
bors-servo added a commit that referenced this pull request Jul 26, 2017
Revert "Auto merge of #17868 - ferjm:bug1380259.radial.gradients, r=xidorn"

This reverts commit ef23338, reversing
changes made to f61528d.

This broke a bunch of tests in m-c, like:

  https://treeherder.mozilla.org/logviewer.html#?job_id=118007409&repo=autoland

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17871)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.