Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatrixDecomposed3D.add_weighted() is called with zero value for other… #17879

Merged
merged 1 commit into from Jul 27, 2017

Conversation

Projects
None yet
4 participants
@hiikezoe
Copy link
Contributor

commented Jul 26, 2017

…_portion in case of iteration composite.

In the case where we accumulate transform:none onto decomposed matrix for
iteration composite whose iteration count is over 2, we pass zero
other_portion and self_portion which is over 1.0. We should care about the
case.

https://bugzilla.mozilla.org/show_bug.cgi?id=1383493


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable

Hiroyuki Ikezoe
MatrixDecomposed3D.add_weighted() is called with zero value for other…
…_portion in case of iteration composite.

In the case where we accumulate transform:none onto decomposed matrix for
iteration composite whose iteration count is over 2, we pass zero
other_portion and self_portion which is over 1.0.  We should care about the
case.
@hiikezoe

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2017

@bors-servo r=birtles

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2017

📌 Commit 123e5d3 has been approved by birtles

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2017

⌛️ Testing commit 123e5d3 with merge 62aabff...

bors-servo added a commit that referenced this pull request Jul 26, 2017

Auto merge of #17879 - hiikezoe:fix-assert, r=birtles
MatrixDecomposed3D.add_weighted() is called with zero value for other…

…_portion in case of iteration composite.

In the case where we accumulate transform:none onto decomposed matrix for
iteration composite whose iteration count is over 2, we pass zero
other_portion and self_portion which is over 1.0.  We should care about the
case.

https://bugzilla.mozilla.org/show_bug.cgi?id=1383493

<!-- Please describe your changes on the following line: -->
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17879)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2017

💔 Test failed - linux-rel-css

@hiikezoe

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2017

@bors-servo retry

@KiChjang

This comment has been minimized.

Copy link
Member

commented Jul 27, 2017

@bors-servo r-

Sorry, is this a new intermittent, or a legitimate test failure? If it's the former, please file a new issue about it.

@hiikezoe

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2017

#17885 ?

@hiikezoe

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2017

I believe @jdm filed the issue on behalf of me. :)
@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2017

📌 Commit 123e5d3 has been approved by hiikezoe

@KiChjang

This comment has been minimized.

Copy link
Member

commented Jul 27, 2017

Okay, please do link to the intermittent issue when you retry due to an intermittent, it helps us keep track of where it was first detected. Thanks!

@bors-servo retry

@hiikezoe

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2017

Thanks for the notice. I will do it next time.

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2017

⌛️ Testing commit 123e5d3 with merge b38d3f2...

bors-servo added a commit that referenced this pull request Jul 27, 2017

Auto merge of #17879 - hiikezoe:fix-assert, r=hiikezoe
MatrixDecomposed3D.add_weighted() is called with zero value for other…

…_portion in case of iteration composite.

In the case where we accumulate transform:none onto decomposed matrix for
iteration composite whose iteration count is over 2, we pass zero
other_portion and self_portion which is over 1.0.  We should care about the
case.

https://bugzilla.mozilla.org/show_bug.cgi?id=1383493

<!-- Please describe your changes on the following line: -->
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17879)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2017

@bors-servo bors-servo merged commit 123e5d3 into servo:master Jul 27, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.