Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up traversal modes #17895

Merged
merged 6 commits into from Jul 28, 2017
Merged

Clean up traversal modes #17895

merged 6 commits into from Jul 28, 2017

Conversation

@bholley
Copy link
Contributor

bholley commented Jul 27, 2017 •
edited by larsbergstrom

https://bugzilla.mozilla.org/show_bug.cgi?id=1384769

This change is Reviewable
@highfive
Copy link

highfive commented Jul 27, 2017

Heads up! This PR modifies the following files:

  • @canaltinova: components/style/lib.rs, components/style/gecko/generated/structs_debug.rs, components/style/invalidation/element/restyle_hints.rs, components/style/gecko/generated/structs_release.rs, components/style/gecko/generated/bindings.rs and 5 more
  • @emilio: components/style/lib.rs, components/style/gecko/generated/structs_debug.rs, ports/geckolib/glue.rs, components/style/invalidation/element/restyle_hints.rs, components/style/gecko/generated/structs_release.rs and 6 more
@highfive
Copy link

highfive commented Jul 27, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@bholley
Copy link
Contributor Author

bholley commented Jul 27, 2017

@bors-servo r=emilio p=2
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2017

📌 Commit 5d51273 has been approved by emilio
@highfive highfive assigned emilio and unassigned glennw Jul 27, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2017

⌛ Testing commit 5d51273 with merge 888ef02...
bors-servo added a commit that referenced this pull request Jul 27, 2017
@bors-servo
Auto merge of #17895 - bholley:clean_up_traversal, r=emilio
Loading status checks…
888ef02 
Clean up traversal modes

https://bugzilla.mozilla.org/show_bug.cgi?id=1384769
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2017

💔 Test failed - linux-dev
bholley added 6 commits Jul 26, 2017
@bholley
Pass TraversalFlags from C++ into Rust.
ce295f6 
MozReview-Commit-ID: EVUzgnL5coN
@bholley
Clean up ForThrottledAnimationFlush stuff.
543bbb7 
MozReview-Commit-ID: I6xeHv65nH2
@bholley
Get rid of the ForNewlyBoundElement mode.
68c8808 
MozReview-Commit-ID: 1IRn2iaPnVc
@bholley
Stop unconditionally traversing every element in the subtree on recon…
5c6d3b8 
…struct traversals.

We already have a more-specific check further down in the file, which was added in the same revision.
I think this one was erroneous.

MozReview-Commit-ID: CnP0zCpBtnp
@bholley
Break TraversalFlags::ForReconstruct down into several independent pi…
6148db6 
…eces.

These will be useful in followup work.

MozReview-Commit-ID: Dyp9R0PG36v
@bholley
Update checked-in bindings.
Loading status checks…
5a15504 
MozReview-Commit-ID: 34zO9Jp9VEr
@bholley bholley force-pushed the bholley:clean_up_traversal branch from 5d51273 to 5a15504 Jul 27, 2017
@bholley
Copy link
Contributor Author

bholley commented Jul 27, 2017

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2017

📌 Commit 5a15504 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2017

⌛ Testing commit 5a15504 with merge 255c9d0...
bors-servo added a commit that referenced this pull request Jul 27, 2017
@bors-servo
Auto merge of #17895 - bholley:clean_up_traversal, r=emilio
Loading status checks…
255c9d0 
Clean up traversal modes

https://bugzilla.mozilla.org/show_bug.cgi?id=1384769

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17895)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 255c9d0 to master...
@bors-servo bors-servo merged commit 5a15504 into servo:master Jul 28, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jul 28, 2017
Merged
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@bholley @highfive @bors-servo @emilio @glennw
You can’t perform that action at this time.