Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWR multi-document update - try 2 #17908
Conversation
|
@bors-servo r+ |
|
|
Make webrender_api a servo-only dependency of style_traits <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #17907 <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because _____ new logic is added <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17908) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
|
|
|
kvark
changed the title
|
@asajeffrey given that the original PR got reverted, I re-incorporated it here. Please take another look. |
|
@bors-servo r+ |
|
|
WR multi-document update - try 2 <!-- Please describe your changes on the following line: --> Combines #17892 with the patch to detach style_traits from webrender_api --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #17907 <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because _____ new logic is added <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17908) <!-- Reviewable:end -->
|
|
kvark commentedJul 28, 2017
•
edited
Combines #17892 with the patch to detach style_traits from webrender_api
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is