New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WR multi-document update - try 2 #17908
Conversation
@bors-servo r+ |
📌 Commit 7a25897 has been approved by |
Make webrender_api a servo-only dependency of style_traits <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #17907 <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because _____ new logic is added <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17908) <!-- Reviewable:end -->
💔 Test failed - linux-rel-css |
@bors-servo retry |
⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-css2, mac-rel-wpt4... |
⛄ The build was interrupted to prioritize another pull request. |
☔ The latest upstream changes (presumably #17910) made this pull request unmergeable. Please resolve the merge conflicts. |
@asajeffrey given that the original PR got reverted, I re-incorporated it here. Please take another look. |
@bors-servo r+ |
📌 Commit 101c426 has been approved by |
WR multi-document update - try 2 <!-- Please describe your changes on the following line: --> Combines #17892 with the patch to detach style_traits from webrender_api --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #17907 <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because _____ new logic is added <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17908) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
Combines #17892 with the patch to detach style_traits from webrender_api
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is