Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMultiple gecko backouts #17910
Multiple gecko backouts #17910
Conversation
|
@bors-servo r+ force p=9001 treeclosed=9000 |
|
|
highfive
commented
Jul 28, 2017
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. |
highfive
commented
Jul 28, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 28, 2017
|
@bors-servo: treeclosed- |
|
@bors-servo: treeclosed=9000 |
|
@bors-servo r+ force p=9001 treeclosed=9000 |
|
|
|
|
@bors-servo treeclosed- |
Multiple gecko backouts Backed out changeset a417b9d7712d for vendoring bustage. r=backout on a CLOSED TREE Backs out #17565 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17910) <!-- Reviewable:end --> --- Backed out changeset c424ad1c5f94 for build failures a=backout CLOSED TREE Backs out #17892
|
@bors-servo treeclosed=9000 |
|
So #17565 is probably innocent, and #17892 is gulity for the bustage on Gecko tree. The reason is that #17892 makes style_traits depend on webrender, while Gecko already has a webrender vendored in another place in the tree, which causes this problem. I'm not sure what should we do here. There are two potential solutions:
Both of them have drawbacks, though. For the first one, it means updating that crate would take more effort. If those types aren't updated frequently, this might be the best solution. For the second one, I suppose it would make development harder for Quantum Render project, because third_party is not mutable in Gecko, so they would not be able to update code simultaneously without more complicated setup. It would make it much like how Stylo project looks like before we vendor Servo into Gecko tree. |
|
|
moz-servo-sync commentedJul 28, 2017
•
edited
Backed out changeset a417b9d7712d for vendoring bustage. r=backout on a CLOSED TREE
Backs out #17565
This change is
Backed out changeset c424ad1c5f94 for build failures a=backout CLOSED TREE
Backs out #17892