Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRun the async HTML Tokenizer on a new thread #17914
Merged
Conversation
highfive
commented
Jul 29, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 29, 2017
|
|
components/selectors/context.rs
Outdated
| @@ -49,6 +49,7 @@ pub enum VisitedHandlingMode { | |||
| /// | |||
| /// See: https://quirks.spec.whatwg.org/ | |||
| #[derive(PartialEq, Eq, Copy, Clone, Hash, Debug)] | |||
| #[cfg_attr(feature = "servo", derive(HeapSizeOf))] | |||
This comment has been minimized.
This comment has been minimized.
emilio
Jul 29, 2017
Member
Given selectors doesn't have a servo feature, this is dead code right now. Could you revert the selectors changes?
cynicaldevil
force-pushed the
cynicaldevil:new-parser-thread
branch
from
0f34f4e
to
04c1588
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 29, 2017
Run the async HTML Tokenizer on a new thread <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors Follow up for #17565 <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17914) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cynicaldevil commentedJul 29, 2017
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsFollow up for #17565
This change is