Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new flag and use it to be more permissive about cousin sharing #17980

Merged
merged 1 commit into from Aug 5, 2017
Merged

Introduce a new flag and use it to be more permissive about cousin sharing #17980

merged 1 commit into from Aug 5, 2017

Conversation

@bholley
Copy link
Contributor

bholley commented Aug 5, 2017 •
edited by SimonSapin

https://bugzilla.mozilla.org/show_bug.cgi?id=1387116

This change is Reviewable
@bholley
Introduce a new flag and use it to be more permissive about cousin sh…
Loading status checks…
54c5291 
…aring.

MozReview-Commit-ID: BCJg0Ycsy6M
@highfive
Copy link

highfive commented Aug 5, 2017

Heads up! This PR modifies the following files:

  • @canaltinova: components/style/data.rs, components/style/sharing/mod.rs, components/style/traversal.rs, components/style/sharing/checks.rs
  • @emilio: components/style/data.rs, components/style/sharing/mod.rs, components/style/traversal.rs, components/style/sharing/checks.rs
@highfive
Copy link

highfive commented Aug 5, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@bholley
Copy link
Contributor Author

bholley commented Aug 5, 2017

@bors-servo r=emilio p=1
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2017

📌 Commit 54c5291 has been approved by emilio
@highfive highfive assigned emilio and unassigned jdm Aug 5, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2017

⌛ Testing commit 54c5291 with merge b701d72...
bors-servo added a commit that referenced this pull request Aug 5, 2017
@bors-servo
Auto merge of #17980 - bholley:fix_initial_sharing, r=emilio
Loading status checks…
b701d72 
Introduce a new flag and use it to be more permissive about cousin sharing

https://bugzilla.mozilla.org/show_bug.cgi?id=1387116

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17980)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing b701d72 to master...
@bors-servo bors-servo merged commit 54c5291 into servo:master Aug 5, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@ionutgoldan
Copy link

ionutgoldan commented Aug 7, 2017

Looks like this brought a noticeable improvement:

== Change summary for alert #8585 (as of August 05 2017 09:41 UTC) ==

Improvements:

7% tp6_amazon summary windows10-64 opt 1_thread e10s stylo 688.38 -> 637.00
7% tp6_amazon summary windows10-64 pgo 1_thread e10s stylo 628.58 -> 585.25

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=8585
@ionutgoldan
Copy link

ionutgoldan commented Aug 7, 2017

If this improvement somehow wasn't expected, please don't hesitate to email me at ionut.goldan@softvision.ro
@emilio
Copy link
Member

emilio commented Aug 7, 2017 •
edited

This kind of was expected, but there should've been a regression before from https://bugzilla.mozilla.org/show_bug.cgi?id=1381821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@bholley @highfive @bors-servo @ionutgoldan @emilio @jdm
You can’t perform that action at this time.