Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMore refactoring of the traversal in preparation for restyle roots #18048
Conversation
Doing anything else is non-sensical, since we're not guaranteed to reach all of the bits from traversal Y when doing traversal X. MozReview-Commit-ID: FQliRxBan70
MozReview-Commit-ID: 4BK0JfkgjdC
The buggy animation handling isn't a regression, since currently we pass UnstyledChildrenOnly in those cases, which blocks the animation traversal in Servo_TraverseSubtree. In general I really wanted to handle these two paths together. But there's enough broken with the NewChildren path that I wanted to scope the buginess as tightly as possible. And I really need to separate the handling here from StyleDocument() to make the restyle root stuff work. MozReview-Commit-ID: 9F0mcQl7AAX
… Servo. MozReview-Commit-ID: 83DgB1sZnCb
highfive
commented
Aug 11, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Aug 11, 2017
|
|
|
@bors-servo r=emilio p=1 |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 11, 2017
…_roots, r=emilio More refactoring of the traversal in preparation for restyle roots https://bugzilla.mozilla.org/show_bug.cgi?id=1389347
|
|
|
Forgot to update the bindings. @bors-servo r=emilio |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 11, 2017
…_roots, r=emilio More refactoring of the traversal in preparation for restyle roots https://bugzilla.mozilla.org/show_bug.cgi?id=1389347 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18048) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
|
|
@bors-servo retry |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 11, 2017
Continue after failed attempt to delete old nightly Failure to catch this error broke bholley's PR #18048 http://build.servo.org/builders/linux-dev/builds/8616/steps/shell__1/logs/stdio. Logs below for posterity. ``` Current Rust nightly version: 599be0d18f4c6ddf36366d2a5a2ca6dc65886896 Current Rust stable version: 1.19.0 Removing /home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434 Error running mach: ['clean-nightlies', '--keep', '3', '--force'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: OSError: [Errno 2] No such file or directory: '/home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434' File "/home/servo/buildbot/slave/linux-dev/build/python/servo/bootstrap_commands.py", line 334, in clean_nightlies delete(full_path) File "/home/servo/buildbot/slave/linux-dev/build/python/servo/util.py", line 28, in delete os.remove(path) ``` I don't know how the builder got into the edge case where the old nightly wasn't there for deletion, but in the case that removal fails for some reason, mach should just keep going. In the incredibly unlikely event that the failure to remove the file has consequences down the line, we'll have the failed remove in the log for troubleshooting. Also this passed tidy so if I failed to python I'll need to fix tidy as well as this. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18051) <!-- Reviewable:end -->
|
@bors-servo retry |
1 similar comment
|
@bors-servo retry |
|
@bors-servo force |
|
|
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Aug 11, 2017
…_roots, r=emilio More refactoring of the traversal in preparation for restyle roots https://bugzilla.mozilla.org/show_bug.cgi?id=1389347 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18048) <!-- Reviewable:end -->
|
|
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 12, 2017
…htly (from edunham:cleannightly); r=larsbergstrom Failure to catch this error broke bholley's PR servo/servo#18048 http://build.servo.org/builders/linux-dev/builds/8616/steps/shell__1/logs/stdio. Logs below for posterity. ``` Current Rust nightly version: 599be0d18f4c6ddf36366d2a5a2ca6dc65886896 Current Rust stable version: 1.19.0 Removing /home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434 Error running mach: ['clean-nightlies', '--keep', '3', '--force'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: OSError: [Errno 2] No such file or directory: '/home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434' File "/home/servo/buildbot/slave/linux-dev/build/python/servo/bootstrap_commands.py", line 334, in clean_nightlies delete(full_path) File "/home/servo/buildbot/slave/linux-dev/build/python/servo/util.py", line 28, in delete os.remove(path) ``` I don't know how the builder got into the edge case where the old nightly wasn't there for deletion, but in the case that removal fails for some reason, mach should just keep going. In the incredibly unlikely event that the failure to remove the file has consequences down the line, we'll have the failed remove in the log for troubleshooting. Also this passed tidy so if I failed to python I'll need to fix tidy as well as this. Source-Repo: https://github.com/servo/servo Source-Revision: 3ed6c22e45df06bf381356b394d01493fc0322a2 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : cf30cf007ef6e071b1852fbbd8b3b9f20b3f536d
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Aug 14, 2017
…htly (from edunham:cleannightly); r=larsbergstrom Failure to catch this error broke bholley's PR servo/servo#18048 http://build.servo.org/builders/linux-dev/builds/8616/steps/shell__1/logs/stdio. Logs below for posterity. ``` Current Rust nightly version: 599be0d18f4c6ddf36366d2a5a2ca6dc65886896 Current Rust stable version: 1.19.0 Removing /home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434 Error running mach: ['clean-nightlies', '--keep', '3', '--force'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: OSError: [Errno 2] No such file or directory: '/home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434' File "/home/servo/buildbot/slave/linux-dev/build/python/servo/bootstrap_commands.py", line 334, in clean_nightlies delete(full_path) File "/home/servo/buildbot/slave/linux-dev/build/python/servo/util.py", line 28, in delete os.remove(path) ``` I don't know how the builder got into the edge case where the old nightly wasn't there for deletion, but in the case that removal fails for some reason, mach should just keep going. In the incredibly unlikely event that the failure to remove the file has consequences down the line, we'll have the failed remove in the log for troubleshooting. Also this passed tidy so if I failed to python I'll need to fix tidy as well as this. Source-Repo: https://github.com/servo/servo Source-Revision: 3ed6c22e45df06bf381356b394d01493fc0322a2
aethanyc
pushed a commit
to aethanyc/gecko-dev
that referenced
this pull request
Aug 15, 2017
…htly (from edunham:cleannightly); r=larsbergstrom Failure to catch this error broke bholley's PR servo/servo#18048 http://build.servo.org/builders/linux-dev/builds/8616/steps/shell__1/logs/stdio. Logs below for posterity. ``` Current Rust nightly version: 599be0d18f4c6ddf36366d2a5a2ca6dc65886896 Current Rust stable version: 1.19.0 Removing /home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434 Error running mach: ['clean-nightlies', '--keep', '3', '--force'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: OSError: [Errno 2] No such file or directory: '/home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434' File "/home/servo/buildbot/slave/linux-dev/build/python/servo/bootstrap_commands.py", line 334, in clean_nightlies delete(full_path) File "/home/servo/buildbot/slave/linux-dev/build/python/servo/util.py", line 28, in delete os.remove(path) ``` I don't know how the builder got into the edge case where the old nightly wasn't there for deletion, but in the case that removal fails for some reason, mach should just keep going. In the incredibly unlikely event that the failure to remove the file has consequences down the line, we'll have the failed remove in the log for troubleshooting. Also this passed tidy so if I failed to python I'll need to fix tidy as well as this. Source-Repo: https://github.com/servo/servo Source-Revision: 3ed6c22e45df06bf381356b394d01493fc0322a2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…htly (from edunham:cleannightly); r=larsbergstrom Failure to catch this error broke bholley's PR servo/servo#18048 http://build.servo.org/builders/linux-dev/builds/8616/steps/shell__1/logs/stdio. Logs below for posterity. ``` Current Rust nightly version: 599be0d18f4c6ddf36366d2a5a2ca6dc65886896 Current Rust stable version: 1.19.0 Removing /home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434 Error running mach: ['clean-nightlies', '--keep', '3', '--force'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: OSError: [Errno 2] No such file or directory: '/home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434' File "/home/servo/buildbot/slave/linux-dev/build/python/servo/bootstrap_commands.py", line 334, in clean_nightlies delete(full_path) File "/home/servo/buildbot/slave/linux-dev/build/python/servo/util.py", line 28, in delete os.remove(path) ``` I don't know how the builder got into the edge case where the old nightly wasn't there for deletion, but in the case that removal fails for some reason, mach should just keep going. In the incredibly unlikely event that the failure to remove the file has consequences down the line, we'll have the failed remove in the log for troubleshooting. Also this passed tidy so if I failed to python I'll need to fix tidy as well as this. Source-Repo: https://github.com/servo/servo Source-Revision: 3ed6c22e45df06bf381356b394d01493fc0322a2 UltraBlame original commit: 34ac8e0443d80a4f34dcc6999144e13b81b271ea
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…htly (from edunham:cleannightly); r=larsbergstrom Failure to catch this error broke bholley's PR servo/servo#18048 http://build.servo.org/builders/linux-dev/builds/8616/steps/shell__1/logs/stdio. Logs below for posterity. ``` Current Rust nightly version: 599be0d18f4c6ddf36366d2a5a2ca6dc65886896 Current Rust stable version: 1.19.0 Removing /home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434 Error running mach: ['clean-nightlies', '--keep', '3', '--force'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: OSError: [Errno 2] No such file or directory: '/home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434' File "/home/servo/buildbot/slave/linux-dev/build/python/servo/bootstrap_commands.py", line 334, in clean_nightlies delete(full_path) File "/home/servo/buildbot/slave/linux-dev/build/python/servo/util.py", line 28, in delete os.remove(path) ``` I don't know how the builder got into the edge case where the old nightly wasn't there for deletion, but in the case that removal fails for some reason, mach should just keep going. In the incredibly unlikely event that the failure to remove the file has consequences down the line, we'll have the failed remove in the log for troubleshooting. Also this passed tidy so if I failed to python I'll need to fix tidy as well as this. Source-Repo: https://github.com/servo/servo Source-Revision: 3ed6c22e45df06bf381356b394d01493fc0322a2 UltraBlame original commit: 34ac8e0443d80a4f34dcc6999144e13b81b271ea
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…htly (from edunham:cleannightly); r=larsbergstrom Failure to catch this error broke bholley's PR servo/servo#18048 http://build.servo.org/builders/linux-dev/builds/8616/steps/shell__1/logs/stdio. Logs below for posterity. ``` Current Rust nightly version: 599be0d18f4c6ddf36366d2a5a2ca6dc65886896 Current Rust stable version: 1.19.0 Removing /home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434 Error running mach: ['clean-nightlies', '--keep', '3', '--force'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: OSError: [Errno 2] No such file or directory: '/home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434' File "/home/servo/buildbot/slave/linux-dev/build/python/servo/bootstrap_commands.py", line 334, in clean_nightlies delete(full_path) File "/home/servo/buildbot/slave/linux-dev/build/python/servo/util.py", line 28, in delete os.remove(path) ``` I don't know how the builder got into the edge case where the old nightly wasn't there for deletion, but in the case that removal fails for some reason, mach should just keep going. In the incredibly unlikely event that the failure to remove the file has consequences down the line, we'll have the failed remove in the log for troubleshooting. Also this passed tidy so if I failed to python I'll need to fix tidy as well as this. Source-Repo: https://github.com/servo/servo Source-Revision: 3ed6c22e45df06bf381356b394d01493fc0322a2 UltraBlame original commit: 34ac8e0443d80a4f34dcc6999144e13b81b271ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bholley commentedAug 11, 2017
•
edited by SimonSapin
https://bugzilla.mozilla.org/show_bug.cgi?id=1389347
This change is