Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upContinue after failed attempt to delete old nightly #18051
Merged
Conversation
Failure to catch this error broke bholley's PR: http://build.servo.org/builders/linux-dev/builds/8616/steps/shell__1/logs/stdio. Logs below for posterity. Current Rust nightly version: 599be0d18f4c6ddf36366d2a5a2ca6dc65886896 Current Rust stable version: 1.19.0 Removing /home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434 Error running mach: ['clean-nightlies', '--keep', '3', '--force'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: OSError: [Errno 2] No such file or directory: '/home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434' File "/home/servo/buildbot/slave/linux-dev/build/python/servo/bootstrap_commands.py", line 334, in clean_nightlies delete(full_path) File "/home/servo/buildbot/slave/linux-dev/build/python/servo/util.py", line 28, in delete os.remove(path)
highfive
commented
Aug 11, 2017
|
Heads up! This PR modifies the following files:
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 11, 2017
Continue after failed attempt to delete old nightly Failure to catch this error broke bholley's PR #18048 http://build.servo.org/builders/linux-dev/builds/8616/steps/shell__1/logs/stdio. Logs below for posterity. ``` Current Rust nightly version: 599be0d18f4c6ddf36366d2a5a2ca6dc65886896 Current Rust stable version: 1.19.0 Removing /home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434 Error running mach: ['clean-nightlies', '--keep', '3', '--force'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: OSError: [Errno 2] No such file or directory: '/home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434' File "/home/servo/buildbot/slave/linux-dev/build/python/servo/bootstrap_commands.py", line 334, in clean_nightlies delete(full_path) File "/home/servo/buildbot/slave/linux-dev/build/python/servo/util.py", line 28, in delete os.remove(path) ``` I don't know how the builder got into the edge case where the old nightly wasn't there for deletion, but in the case that removal fails for some reason, mach should just keep going. In the incredibly unlikely event that the failure to remove the file has consequences down the line, we'll have the failed remove in the log for troubleshooting. Also this passed tidy so if I failed to python I'll need to fix tidy as well as this. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18051) <!-- Reviewable:end -->
|
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
edunham commentedAug 11, 2017
•
edited by SimonSapin
Failure to catch this error broke bholley's PR #18048
http://build.servo.org/builders/linux-dev/builds/8616/steps/shell__1/logs/stdio.
Logs below for posterity.
I don't know how the builder got into the edge case where the old nightly wasn't there for deletion, but in the case that removal fails for some reason, mach should just keep going. In the incredibly unlikely event that the failure to remove the file has consequences down the line, we'll have the failed remove in the log for troubleshooting.
Also this passed tidy so if I failed to python I'll need to fix tidy as well as this.
This change is