Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enqueue attribute changed callback when replacing attr #18074

Merged
merged 1 commit into from Aug 14, 2017

Conversation

@cbrewster
Copy link
Member

commented Aug 14, 2017


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Aug 14, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/element.rs
  • @KiChjang: components/script/dom/element.rs
@cbrewster

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2017

r? @jdm

@highfive highfive assigned jdm and unassigned emilio Aug 14, 2017

@jdm

This comment has been minimized.

Copy link
Member

commented Aug 14, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2017

📌 Commit 221b099 has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2017

⌛️ Testing commit 221b099 with merge 5c9ba6e...

bors-servo added a commit that referenced this pull request Aug 14, 2017
Auto merge of #18074 - cbrewster:set_attr_node, r=jdm
Enqueue attribute changed callback when replacing attr

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18074)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2017

@bors-servo bors-servo merged commit 221b099 into servo:master Aug 14, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.