Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check pref when parsing :fullscreen pseudo-class #18076

Merged
merged 1 commit into from Aug 15, 2017

Conversation

@upsuper
Copy link
Member

commented Aug 15, 2017

This is the Servo side change of bug 1374902.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Aug 15, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/selector_parser.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/non_ts_pseudo_class_list.rs, components/style/gecko/generated/structs_release.rs
  • @canaltinova: components/style/gecko/selector_parser.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/non_ts_pseudo_class_list.rs, components/style/gecko/generated/structs_release.rs
  • @emilio: components/style/gecko/selector_parser.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/non_ts_pseudo_class_list.rs, components/style/gecko/generated/structs_release.rs
@highfive

This comment has been minimized.

Copy link

commented Aug 15, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@upsuper

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2017

@bors-servo r=TYLin p=10

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2017

📌 Commit d3baa4f has been approved by TYLin

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2017

⌛️ Testing commit d3baa4f with merge 4771e6e...

bors-servo added a commit that referenced this pull request Aug 15, 2017
Check pref when parsing :fullscreen pseudo-class

This is the Servo side change of [bug 1374902](https://bugzilla.mozilla.org/show_bug.cgi?id=1374902).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18076)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2017

@bors-servo bors-servo merged commit d3baa4f into servo:master Aug 15, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@upsuper upsuper deleted the upsuper:fullscreen-pref branch Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.