Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run DOMTokenList update steps if token was found #18092

Merged
merged 1 commit into from Aug 18, 2017

Conversation

@cbrewster
Copy link
Member

commented Aug 15, 2017


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@cbrewster

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2017

@highfive

This comment has been minimized.

Copy link

commented Aug 15, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/domtokenlist.rs
  • @KiChjang: components/script/dom/domtokenlist.rs
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2017

⌛️ Trying commit 0b6fa8f with merge f66abca1e98d367f4e893d3f5ebb577233bb7bf3...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2017

💔 Test failed - mac-rel-wpt3

@cbrewster

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2017

@bors-servo retry
Infra

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2017

⌛️ Trying commit 0b6fa8f with merge 341d0a9...

bors-servo added a commit that referenced this pull request Aug 15, 2017
Auto merge of #18092 - cbrewster:ce_domtokenlist, r=<try>
Only run DOMTokenList update steps if token was found

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18092)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2017

💥 Test timed out

@nox

This comment has been minimized.

Copy link
Member

commented Aug 16, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2017

⌛️ Trying commit 0b6fa8f with merge 39a1f85...

bors-servo added a commit that referenced this pull request Aug 16, 2017
Auto merge of #18092 - cbrewster:ce_domtokenlist, r=<try>
Only run DOMTokenList update steps if token was found

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18092)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2017

💔 Test failed - android

@jdm

This comment has been minimized.

Copy link
Member

commented Aug 16, 2017

@bors-servo: retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2017

⌛️ Trying commit 0b6fa8f with merge 6a88042...

bors-servo added a commit that referenced this pull request Aug 16, 2017
Auto merge of #18092 - cbrewster:ce_domtokenlist, r=<try>
Only run DOMTokenList update steps if token was found

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18092)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2017

💔 Test failed - mac-dev-unit

@cbrewster

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2017

@bors-servo retry

@cbrewster cbrewster closed this Aug 17, 2017

@cbrewster cbrewster reopened this Aug 17, 2017

@cbrewster

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2017

⌛️ Trying commit 0b6fa8f with merge f399d19...

bors-servo added a commit that referenced this pull request Aug 17, 2017
Auto merge of #18092 - cbrewster:ce_domtokenlist, r=<try>
Only run DOMTokenList update steps if token was found

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18092)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2017

💔 Test failed - mac-rel-wpt3

@jdm

This comment has been minimized.

Copy link
Member

commented Aug 17, 2017

@bors-servo: retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2017

⌛️ Trying commit 0b6fa8f with merge f0ececb...

bors-servo added a commit that referenced this pull request Aug 17, 2017
Auto merge of #18092 - cbrewster:ce_domtokenlist, r=<try>
Only run DOMTokenList update steps if token was found

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18092)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2017

@cbrewster

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2017

r? @jdm

@highfive highfive assigned jdm and unassigned nox Aug 18, 2017

@jdm

This comment has been minimized.

Copy link
Member

commented Aug 18, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2017

📌 Commit 0b6fa8f has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2017

⌛️ Testing commit 0b6fa8f with merge 90a75d4...

bors-servo added a commit that referenced this pull request Aug 18, 2017
Auto merge of #18092 - cbrewster:ce_domtokenlist, r=jdm
Only run DOMTokenList update steps if token was found

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18092)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2017

@bors-servo bors-servo merged commit 0b6fa8f into servo:master Aug 18, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.