Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: Optimize CompareDocumentPosition. #18113

Merged
merged 3 commits into from Aug 17, 2017
Merged

script: Optimize CompareDocumentPosition. #18113

merged 3 commits into from Aug 17, 2017

Conversation

@emilio
Copy link
Member

emilio commented Aug 16, 2017 •
edited by SimonSapin

I need this to compute the proper insertion point for a given stylesheet.

This change is Reviewable
@highfive
Copy link

highfive commented Aug 16, 2017

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Aug 16, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Aug 16, 2017

r? @nox or @jdm or @asajeffrey
@highfive highfive assigned nox and unassigned metajack Aug 16, 2017
@emilio
script: Early return in CompareDocumentPosition to deindent most of t…
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
ccd469c 
…he function.

Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@emilio emilio force-pushed the emilio:node-is-before branch from c084489 to fd8f1e4 Aug 17, 2017
@emilio emilio changed the title script: Add a method to compare the tree position of two nodes. script: Optimize CompareDocumentPosition. Aug 17, 2017
emilio added 2 commits Aug 17, 2017
@emilio
script: Optimize CompareDocumentPosition.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
4304a1d 
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@emilio
script: Add a function to check whether a node is before another one …
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
f6bfd44 
…in DOM order.

Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@emilio emilio force-pushed the emilio:node-is-before branch from fd8f1e4 to f6bfd44 Aug 17, 2017
@emilio
Copy link
Member Author

emilio commented Aug 17, 2017

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

📌 Commit f6bfd44 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

⌛ Testing commit f6bfd44 with merge 18550ed...
bors-servo added a commit that referenced this pull request Aug 17, 2017
@bors-servo
Auto merge of #18113 - emilio:node-is-before, r=nox
Loading status checks…
18550ed 
script: Optimize CompareDocumentPosition.

I need this to compute the proper insertion point for a given stylesheet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18113)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

💔 Test failed - android
@emilio
Copy link
Member Author

emilio commented Aug 17, 2017

@bors-servo retry #18116
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

⚡ Previous build results for linux-dev, mac-dev-unit, windows-msvc-dev are reusable. Rebuilding only android, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

💔 Test failed - android
@emilio
Copy link
Member Author

emilio commented Aug 17, 2017

@bors-servo retry #18116
@KiChjang
Copy link
Member

KiChjang commented Aug 17, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only android...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only android...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only android...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

💔 Test failed - android
@emilio emilio mentioned this pull request Aug 17, 2017
Merged
bors-servo added a commit that referenced this pull request Aug 17, 2017
@bors-servo
Auto merge of #18124 - emilio:stylist-stylesheets, r=<try>
Loading status checks…
73d1357 
style: Replicate the list of stylesheets on the layout thread.

This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in
order to be able to eventually move the stylesheets into the stylist, and be
able to incrementally update the invalidation map.

This is on top of #18113

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124)
<!-- Reviewable:end -->
@emilio
Copy link
Member Author

emilio commented Aug 17, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only android...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

💔 Test failed - android
@emilio
Copy link
Member Author

emilio commented Aug 17, 2017

@bors-servo retry
@emilio
Copy link
Member Author

emilio commented Aug 17, 2017

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #18073
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

📌 Commit f6bfd44 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

⌛ Testing commit f6bfd44 with merge b6e0f4e...
bors-servo added a commit that referenced this pull request Aug 17, 2017
@bors-servo
Auto merge of #18113 - emilio:node-is-before, r=nox
Loading status checks…
b6e0f4e 
script: Optimize CompareDocumentPosition.

I need this to compute the proper insertion point for a given stylesheet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18113)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Aug 17, 2017
@bors-servo
Auto merge of #18124 - emilio:stylist-stylesheets, r=<try>
Loading status checks…
9a5b0a4 
style: Replicate the list of stylesheets on the layout thread.

This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in
order to be able to eventually move the stylesheets into the stylist, and be
able to incrementally update the invalidation map.

This is on top of #18113

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing b6e0f4e to master...
@bors-servo bors-servo merged commit f6bfd44 into servo:master Aug 17, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the emilio:node-is-before branch Aug 17, 2017
bors-servo added a commit that referenced this pull request Aug 17, 2017
@bors-servo
Auto merge of #18124 - emilio:stylist-stylesheets, r=<try>
Loading status checks…
307478b 
style: Replicate the list of stylesheets on the layout thread.

This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in
order to be able to eventually move the stylesheets into the stylist, and be
able to incrementally update the invalidation map.

This is on top of #18113

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Aug 17, 2017
@bors-servo
Auto merge of #18124 - emilio:stylist-stylesheets, r=SimonSapin
Loading status checks…
c4132b9 
style: Replicate the list of stylesheets on the layout thread.

This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in
order to be able to eventually move the stylesheets into the stylist, and be
able to incrementally update the invalidation map.

This is on top of #18113

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Aug 17, 2017
@bors-servo
Auto merge of #18124 - emilio:stylist-stylesheets, r=<try>
Loading status checks…
376b011 
style: Replicate the list of stylesheets on the layout thread.

This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in
order to be able to eventually move the stylesheets into the stylist, and be
able to incrementally update the invalidation map.

This is on top of #18113

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Aug 17, 2017
@bors-servo
Auto merge of #18124 - emilio:stylist-stylesheets, r=SimonSapin
Loading status checks…
056b287 
style: Replicate the list of stylesheets on the layout thread.

This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in
order to be able to eventually move the stylesheets into the stylist, and be
able to incrementally update the invalidation map.

This is on top of #18113

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Aug 18, 2017
@bors-servo
Auto merge of #18124 - emilio:stylist-stylesheets, r=SimonSapin
Loading status checks…
effb69d 
style: Replicate the list of stylesheets on the layout thread.

This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in
order to be able to eventually move the stylesheets into the stylist, and be
able to incrementally update the invalidation map.

This is on top of #18113

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Aug 18, 2017
@bors-servo
Auto merge of #18124 - emilio:stylist-stylesheets, r=SimonSapin
Loading status checks…
495a083 
style: Replicate the list of stylesheets on the layout thread.

This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in
order to be able to eventually move the stylesheets into the stylist, and be
able to incrementally update the invalidation map.

This is on top of #18113

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Aug 18, 2017
@bors-servo
Auto merge of #18124 - emilio:stylist-stylesheets, r=SimonSapin
Loading status checks…
bc4b67d 
style: Replicate the list of stylesheets on the layout thread.

This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in
order to be able to eventually move the stylesheets into the stylist, and be
able to incrementally update the invalidation map.

This is on top of #18113

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Aug 18, 2017
@bors-servo
Auto merge of #18124 - emilio:stylist-stylesheets, r=SimonSapin
Loading status checks…
81a382c 
style: Replicate the list of stylesheets on the layout thread.

This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in
order to be able to eventually move the stylesheets into the stylist, and be
able to incrementally update the invalidation map.

This is on top of #18113

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@emilio @highfive @bors-servo @KiChjang @metajack @nox
You can’t perform that action at this time.