Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert "Auto merge of #17891 - MortimerGoro:webgl_move, r=glennw,emilio" #18114
Conversation
highfive
commented
Aug 16, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Aug 16, 2017
|
cc @MortimerGoro, sorry :( r? @nox |
|
RIP @bors-servo r+ |
|
|
Revert "Auto merge of #17891 - MortimerGoro:webgl_move, r=glennw,emilio" This reverts commit 90f55ea, reversing changes made to 2e60b27. Doing that per Josh's request, since it's causing very frequent intermittent OOMs on the android builders. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18114) <!-- Reviewable:end -->
|
Wow, what could cause that? any ideas? |
|
@jdm what's the best way to try a lot compilations with the android builders in a new PR? Is there any bors-servo command to test compilations only on android builders? I never had that OOM in my local rust compilations. I can try to remove a template parameter from the WebGL thread or the webrender dependency in canvas (just needs a small change in WR). It's the only reasons which I think could cause that kind compilation of error. The other code is normal. |
|
@MortimerGoro It's probably most useful to add your ssh key to https://github.com/servo/saltfs/tree/master/admin/files/ssh and try building directly on the android builder. |
|
|
|
@edunham Can we upgrade all the linux cross builders to something with > 8GB of RAM (at least 16 GB)? |
|
We continue to have memory errors after reverting this PR; my apologies for assigning the blame incorrectly. You are welcome to re-merge these changes. |
|
Closed the new PR, I didn't see that @nox had already created it |
Revert "Auto merge of #18114 - emilio:revert-webgl-refactor, r=nox" This reverts commit 4d10d39, reversing changes made to ee94e2b. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18118) <!-- Reviewable:end -->
Revert "Auto merge of #18114 - emilio:revert-webgl-refactor, r=nox" This reverts commit 4d10d39, reversing changes made to ee94e2b. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18118) <!-- Reviewable:end -->
emilio commentedAug 16, 2017
•
edited by SimonSapin
This reverts commit 90f55ea, reversing
changes made to 2e60b27.
Doing that per Josh's request, since it's causing very frequent intermittent OOMs on the android builders.
This change is