Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved WebGL architecture. #18119

Closed
wants to merge 1 commit into from

Conversation

@MortimerGoro
Copy link
Contributor

MortimerGoro commented Aug 16, 2017

See #17891 and #18114


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive
Copy link

highfive commented Aug 16, 2017

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/pipeline.rs, components/constellation/lib.rs, components/constellation/Cargo.toml, components/constellation/constellation.rs
  • @KiChjang: components/script/dom/webglframebuffer.rs, components/script/dom/webglshader.rs, components/script/dom/webgl_validations/tex_image_2d.rs, components/script/dom/htmlcanvaselement.rs, components/script/dom/window.rs and 24 more
  • @fitzgen: components/script/dom/webglframebuffer.rs, components/script/dom/webglshader.rs, components/script/dom/webgl_validations/tex_image_2d.rs, components/script/dom/htmlcanvaselement.rs, components/script/dom/window.rs and 24 more
  • @emilio: components/layout/display_list_builder.rs, components/script/dom/webglframebuffer.rs, components/script/dom/webglshader.rs, components/script/dom/webgl_validations/tex_image_2d.rs, components/layout/webrender_helpers.rs and 14 more
@highfive
Copy link

highfive commented Aug 16, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify gfx, layout, and script code, but no tests are modified. Please consider adding a test!
@MortimerGoro
Copy link
Contributor Author

MortimerGoro commented Aug 16, 2017

cc @jdm

@atouchet
Copy link
Contributor

atouchet commented Aug 16, 2017

Is this the same change as #18118?

@MortimerGoro
Copy link
Contributor Author

MortimerGoro commented Aug 16, 2017

@atouchet Yes, I didn't see that. Closing this. Thanks for the warning ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.