Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle: Replicate the list of stylesheets on the layout thread. #18124
Conversation
highfive
commented
Aug 17, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Aug 17, 2017
|
@bors-servo try |
style: Replicate the list of stylesheets on the layout thread. This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in order to be able to eventually move the stylesheets into the stylist, and be able to incrementally update the invalidation map. This is on top of #18113 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124) <!-- Reviewable:end -->
|
|
|
r? @SimonSapin |
|
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 13 of 13 files at r4. components/script/dom/document.rs, line 2399 at r4 (raw file):
Shouldn’t this be components/script/dom/node.rs, line 2395 at r2 (raw file):
Nit: Comments from Reviewable |
r=me with that fixed. |
|
Great catch, Simon :) @bors-servo try |
style: Replicate the list of stylesheets on the layout thread. This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in order to be able to eventually move the stylesheets into the stylist, and be able to incrementally update the invalidation map. This is on top of #18113 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124) <!-- Reviewable:end -->
|
|
|
|
@bors-servo try |
style: Replicate the list of stylesheets on the layout thread. This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in order to be able to eventually move the stylesheets into the stylist, and be able to incrementally update the invalidation map. This is on top of #18113 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124) <!-- Reviewable:end -->
|
@bors-servo r=SimonSapin p=1
|
|
|
|
|
style: Replicate the list of stylesheets on the layout thread. This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in order to be able to eventually move the stylesheets into the stylist, and be able to incrementally update the invalidation map. This is on top of #18113 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
style: Replicate the list of stylesheets on the layout thread. This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in order to be able to eventually move the stylesheets into the stylist, and be able to incrementally update the invalidation map. This is on top of #18113 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124) <!-- Reviewable:end -->
|
|
This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in order to be able to eventually move the stylesheets into the stylist, and be able to incrementally update the invalidation map.
|
@bors-servo r=SimonSapin |
|
|
style: Replicate the list of stylesheets on the layout thread. This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in order to be able to eventually move the stylesheets into the stylist, and be able to incrementally update the invalidation map. This is on top of #18113 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18124) <!-- Reviewable:end -->
|
|
emilio commentedAug 17, 2017
•
edited by SimonSapin
This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in
order to be able to eventually move the stylesheets into the stylist, and be
able to incrementally update the invalidation map.
This is on top of #18113
This change is